Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using OrderedDict in GroupBy Module(s) #25692

Closed
WillAyd opened this Issue Mar 12, 2019 · 1 comment

Comments

Projects
None yet
4 participants
@WillAyd
Copy link
Member

WillAyd commented Mar 12, 2019

Spurred by conversation in #25224 (comment) right now we are using plain old dictionaries in most of the groupby aggregation functions. For Py35 this makes the order of the returned result non-deterministic.

We could theoretically make a stronger assertion around the order here by replacing those dicts with OrderedDicts

@WillAyd WillAyd referenced this issue Mar 12, 2019

Merged

Fix concat not respecting order of OrderedDict #25224

3 of 3 tasks complete
@alexander-ponomaroff

This comment has been minimized.

Copy link
Contributor

alexander-ponomaroff commented Mar 12, 2019

Since I've already been working with this, I will also continue with this issue. I'll make a simple WIP PR right now and will continue working on it. I'm thinking of changing the simple dicts to OrderedDicts in the aggregation functions of groupby and writing some tests in order to test the ordering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.