Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: remove PY2 #25725

Open
jreback opened this issue Mar 14, 2019 · 8 comments

Comments

Projects
None yet
5 participants
@jreback
Copy link
Contributor

commented Mar 14, 2019

master issue for removing all vestigaes of Python 2.

After merging: #24942 (removing the PY2 CI jobs) and #25554 (bump numpy to 1.13.3), we will be ready to remove PY2 code, tests, and doc references.

Let's do this in bite sized pieces. IOW don't do a PR with changes for everything.

cc @pandas-dev/pandas-core

@jreback jreback added this to the 0.25.0 milestone Mar 14, 2019

@TomAugspurger

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

Have we discussed whether we continue to support 3.5? Matplotlib master seems to be on 3.6.

@WillAyd

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

I think it would be great to jump to 3.6 eventually for better typing support, f-strings, dict ordering, etc... but at the same time I think it makes sense to rip out the Py27 chunks first before going that route, as there will be plenty as is to clean up

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

step by step here. Let's remove PY2 first. Agree not against dropping 3.5 but should not do all at once.

@TomAugspurger

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

@TomAugspurger

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

That's actually affecting @h-vetinari's other PR; pytest wasn't being bumped correctly on the 3.5 build (since Anaconda doesn't have new enough 3.5 packages for it).

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Mar 17, 2019

ok merged the removal of the CI jobs for PY2: #24942

open season on PY2 removals. but let's do this in a measured way.

cc @pandas-dev/pandas-core

@h-vetinari

This comment has been minimized.

Copy link
Contributor

commented Mar 17, 2019

Before it's open season, I'd suggest to at least merge #25752 first - currently the CI is much reduced from what it was due to the requested hard deletion of PY2-jobs in #24942 (instead of replacing them with new CI jobs).

Another possible candidate to wait for is #25554 (which depends on #25752 in some sense).

gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 24, 2019

@mroeschke mroeschke referenced this issue Mar 26, 2019

Merged

CLN: Remove PY2/3 checks in cython files #25876

3 of 3 tasks complete

gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 26, 2019

gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 26, 2019

@jschendel jschendel referenced this issue Mar 27, 2019

Merged

CLN: Remove __future__ imports #25889

3 of 3 tasks complete

gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 27, 2019

gfyoung added a commit that referenced this issue Mar 27, 2019

gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 28, 2019

gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 28, 2019

gfyoung added a commit to forking-repos/pandas that referenced this issue Mar 28, 2019

gfyoung added a commit that referenced this issue May 5, 2019

gfyoung added a commit that referenced this issue May 8, 2019

gfyoung added a commit that referenced this issue May 10, 2019

Kiku-git added a commit to Kiku-git/pandas that referenced this issue May 16, 2019

Kiku-git added a commit to Kiku-git/pandas that referenced this issue May 16, 2019

Kiku-git added a commit to Kiku-git/pandas that referenced this issue May 16, 2019

Kiku-git added a commit to Kiku-git/pandas that referenced this issue May 16, 2019

@topper-123 topper-123 referenced this issue May 16, 2019

Merged

CLN: remove __unicode__ from code base #26432

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.