Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab completion triggers deprecation warnings with latest Jedi (0.15.1) #27900

Closed
jorisvandenbossche opened this issue Aug 13, 2019 · 5 comments · Fixed by #28524
Milestone

Comments

@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Aug 13, 2019

I reported it at Jedi: davidhalter/jedi#1383
But opening an issue here as well in case there are workarounds we need to do in pandas itself (last time we did do something: #16414)

@jorisvandenbossche jorisvandenbossche added this to the 0.25.1 milestone Aug 13, 2019
@TomAugspurger

This comment has been minimized.

Copy link
Contributor

@TomAugspurger TomAugspurger commented Aug 14, 2019

Sounds like we'll want to put in a workaround to silence these, since we may be releasing before Jedi.

@TomAugspurger

This comment has been minimized.

Copy link
Contributor

@TomAugspurger TomAugspurger commented Aug 20, 2019

I briefly looked into this. Didn't see an easy way to avoid the warnings.

@TomAugspurger TomAugspurger removed this from the 0.25.1 milestone Aug 22, 2019
@jorisvandenbossche

This comment has been minimized.

Copy link
Member Author

@jorisvandenbossche jorisvandenbossche commented Sep 19, 2019

@TomAugspurger last time you did something like

    def __dir__(self):
        # Avoid IPython warnings for deprecated properties
        # https://github.com/pandas-dev/pandas/issues/16409
        rv = set(dir(type(self)))
        rv.discard("labels")
        return sorted(rv)

That did not work this time?
It seem Thomas Kluyver is doing something similar here h5py/h5py#1316

@jorisvandenbossche

This comment has been minimized.

Copy link
Member Author

@jorisvandenbossche jorisvandenbossche commented Sep 19, 2019

This actually seems to be working, will do a PR (we already have the infrastructure set up, but the base list of deprecations was not passed properly to Series)

@jorisvandenbossche

This comment has been minimized.

Copy link
Member Author

@jorisvandenbossche jorisvandenbossche commented Sep 19, 2019

OK, done in #28524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.