Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that Pandas 0.25.2 should be compatible with Python 3.8 #28147

Closed
TomAugspurger opened this issue Aug 26, 2019 · 5 comments · Fixed by #28982 · May be fixed by lizsaret/pandas#1
Labels
Milestone

Comments

@TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Aug 26, 2019

#28101 gets things passing with Python 3.8 locally.

Ideally, we'd have 3.8 actually tested on CI before releasing 0.25.2. Hopefully once conda-forge/python-feedstock#271 is up, we can do that (and maybe build our deps from source).

Once we're tested, we should add a note to the whatsnew saying that pandas 0.25.2 is compatible with Python 3.8

@TomAugspurger TomAugspurger added the Docs label Aug 26, 2019
@TomAugspurger TomAugspurger added this to the 0.25.2 milestone Aug 26, 2019
@TomAugspurger TomAugspurger changed the title Document that Pandas 0.25.2 should be compatible with Document that Pandas 0.25.2 should be compatible with Python 3.8 Aug 26, 2019
@shafaypro

This comment has been minimized.

Copy link

@shafaypro shafaypro commented Aug 27, 2019

GG mate, Yes Indeed.

@TomAugspurger

This comment has been minimized.

Copy link
Contributor Author

@TomAugspurger TomAugspurger commented Aug 30, 2019

Reran with Python 3.8b4. Things seem OK, but a bunch of plotting tests are failing.

@lizsaret

This comment has been minimized.

Copy link
Contributor

@lizsaret lizsaret commented Sep 6, 2019

@TomAugspurger can i work on this?

@TomAugspurger

This comment has been minimized.

Copy link
Contributor Author

@TomAugspurger TomAugspurger commented Sep 6, 2019

This is currently blocked by conda-forge/python-feedstock#271. I'm a bit hesitant to state that we're 3.8 compatible until we're actually testing on CI.

@jreback

This comment has been minimized.

Copy link
Contributor

@jreback jreback commented Sep 6, 2019

agreed we have no testing on 3.8 yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.