TST: Make network decorator impose a skipTest catching URLErrors #3910

Closed
jtratner opened this Issue Jun 15, 2013 · 5 comments

Comments

Projects
None yet
3 participants
Contributor

jtratner commented Jun 15, 2013

Basically, do this in the network decorator:

    @wraps
    def network_wrapper(*args, **kwargs):
        try:
            return t(*args, **kwargs)
        except URLError:
            raise nose.skipTest

Working on it right now

Member

cpcloud commented Jun 15, 2013

@jtratner b4 u spend time on this maybe see pydata#3822

Contributor

jtratner commented Jun 15, 2013

@cpcloud yeah, but it really needs to be opt-out rather than opt-in

Contributor

jreback commented Jun 20, 2013

@cpcloud close this? (as @jtratner put all of the stuff in)

Member

cpcloud commented Jun 20, 2013

this will be closed by #3914

Contributor

jreback commented Jun 20, 2013

great

jreback closed this in #3914 Jun 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment