Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite pandas.util.testing.assert_almost_equal for performance #4398

Closed
wesm opened this issue Jul 29, 2013 · 3 comments · Fixed by #5219

Comments

@wesm
Copy link
Member

commented Jul 29, 2013

I don't know if anyone's profiled the test suite, but we'd get major performance boosts if we wrote a Cython version of assert_almost_equal. Is there another open issue for this already?

@cpcloud

This comment has been minimized.

Copy link
Member

commented Jul 29, 2013

@wesm i think you have one somewhere

@cpcloud

This comment has been minimized.

Copy link
Member

commented Jul 29, 2013

i can't find it though maybe it was something else

danbirken added a commit to danbirken/pandas that referenced this issue Oct 21, 2013
TST/PERF: Re-write assert_almost_equal() in cython pandas-dev#4398
Add a testing.pyx cython file, and port assert_almost_equal() from
python to cython.

On my machine this brings a modest gain to the suite of "not slow" tests
(160s -> 140s), but on assert_almost_equal() heavy tests, like
test_expressions.py, it shows a large improvement (14s -> 4s).
danbirken added a commit to danbirken/pandas that referenced this issue Oct 21, 2013
TST: Fix edge cases in assert_almost_equal() + tests pandas-dev#4398
Many of the edge cases were related to ordering of the items, but in
some cases there were also issues with type checking.  This fixes both
of those issues and massively expands the testing for this function.
@danbirken

This comment has been minimized.

Copy link
Contributor

commented Oct 21, 2013

FYI: #3150 is the duplicate of this one that was theorized to exist in the initial message

jreback added a commit that referenced this issue Oct 21, 2013
Merge pull request #5219 from danbirken/c_assert_almost_equal_simple
TST/PERF: Re-write assert_almost_equal() in cython #4398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.