New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Series.mask with small int dtypes raising #45750
Conversation
can you add a whatsnew here |
tm.assert_series_equal(ser2, expected) | ||
|
||
# FIXME: don't leave commented-out | ||
# FIXME: ser.where(~mask, alt) unnecessarily upcasts to int64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an xfail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably. i didnt want to make it a separate test bc im planning/hoping to move the whole thing into a SetitemCastingEquivalents subclass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay fine as is then
whatsnew added + green |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.