/pandas

New issue

DEPR: deprecate cols / change to subset in duplicated/drop_duplicates #6680

Closed
jreback opened this Issue Mar 21, 2014 · 4 comments

Comments

Assignees
No one assigned
Labels
Deprecate
Projects
None yet
Milestone
  0.14.0
2 participants
@jreback @jsexauer
@jreback
Contributor

jreback commented Mar 21, 2014

for consistency with dropna (and also to not use cols which is being deprecated)

related #6645

jreback added this to the 0.14.0 milestone Mar 21, 2014

jreback added the API Design label Mar 21, 2014

jreback changed the title from DEPR: change cols to subset in duplicated/drop_duplicates to DEPR: deprecate cols / change to subset in duplicated/drop_duplicates Mar 21, 2014

@jreback jreback added Deprecate and removed API Design labels Mar 21, 2014

This was referenced Mar 22, 2014

Closed
Open
@jsexauer
Contributor

jsexauer commented Mar 23, 2014

In working on this, the only unit tests I could find for duplicated where in pandas/tseries/tests/test_timeseries.py. Shouldn't there be some tests in pandas/tests/test_frame.py? Regardless, where would you like to see the unit test the verifies the warnings are errors are raised as expected?
@jsexauer
Contributor

jsexauer commented Mar 23, 2014

Also, can I please assigned to this so I can convert this issue into a pr? Thanks.
@jreback
Contributor

jreback commented Mar 23, 2014

go ahead

hmm should be some tests for duplicated/drop_duplicates in test_frame

if not prob just the underlying routines see tested

pls add a suite of tests (including the depr warning tests)

thanks

jsexauer referenced this issue Mar 23, 2014

Closed

DEPR: Deprecate cols in several functions #6693

@jreback
Contributor

jreback commented Mar 25, 2014

closed by #6693

jreback closed this Mar 25, 2014

jreback referenced this issue Apr 24, 2014

Closed

Unify argument conventions #2062

@jreback jreback added a commit to jreback/pandas that referenced this issue Jan 28, 2016

@jreback jreback DEPR: Removal of cols keyword in favor of subset in DataFrame.duplica… 
…ted() and DataFrame.drop_duplicates(), xref #6680
 e3579a5

jreback referenced this issue Jan 28, 2016

Closed

DEPR: some removals #12165

@jreback jreback added a commit that referenced this issue Jan 28, 2016

@jreback jreback DEPR: some removals 
DEPR: Removal of cols keyword in favor of subset in
DataFrame.duplicated() and DataFrame.drop_duplicates(), xref #6680

Author: Jeff Reback <jeff@reback.net>

Closes #12165 from jreback/deprecate and squashes the following commits:

5be6dc6 [Jeff Reback] DOC: small fix on Timestamp doc-string
e3579a5 [Jeff Reback] DEPR: Removal of cols keyword in favor of subset in DataFrame.duplicated() and DataFrame.drop_duplicates(), xref #6680
 bb94ebe

jreback referenced this issue Jul 24, 2016

Open

DEPR: deprecations log for removed issues #13777

65 of 65 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment