Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: deprecate cols / change to subset in duplicated/drop_duplicates #6680

Closed
jreback opened this issue Mar 21, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@jreback
Copy link
Contributor

commented Mar 21, 2014

for consistency with dropna (and also to not use cols which is being deprecated)

related #6645

@jreback jreback added this to the 0.14.0 milestone Mar 21, 2014

@jreback jreback added the API Design label Mar 21, 2014

@jreback jreback changed the title DEPR: change cols to subset in duplicated/drop_duplicates DEPR: deprecate cols / change to subset in duplicated/drop_duplicates Mar 21, 2014

@jreback jreback added Deprecate and removed API Design labels Mar 21, 2014

@jsexauer jsexauer referenced this issue Mar 22, 2014

Open

DEPR: deprecations from prior versions #6581

0 of 97 tasks complete
@jsexauer

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2014

In working on this, the only unit tests I could find for duplicated where in pandas/tseries/tests/test_timeseries.py. Shouldn't there be some tests in pandas/tests/test_frame.py? Regardless, where would you like to see the unit test the verifies the warnings are errors are raised as expected?

@jsexauer

This comment has been minimized.

Copy link
Contributor

commented Mar 23, 2014

Also, can I please assigned to this so I can convert this issue into a pr? Thanks.

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2014

go ahead

hmm should be some tests for duplicated/drop_duplicates in test_frame

if not prob just the underlying routines see tested

pls add a suite of tests (including the depr warning tests)

thanks

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2014

closed by #6693

@jreback jreback closed this Mar 25, 2014

jreback added a commit to jreback/pandas that referenced this issue Jan 28, 2016

jreback added a commit that referenced this issue Jan 28, 2016

DEPR: some removals
DEPR: Removal of cols keyword in favor of subset in
DataFrame.duplicated() and DataFrame.drop_duplicates(), xref #6680

Author: Jeff Reback <jeff@reback.net>

Closes #12165 from jreback/deprecate and squashes the following commits:

5be6dc6 [Jeff Reback] DOC: small fix on Timestamp doc-string
e3579a5 [Jeff Reback] DEPR: Removal of cols keyword in favor of subset in DataFrame.duplicated() and DataFrame.drop_duplicates(), xref #6680

@jreback jreback referenced this issue Jul 24, 2016

Open

DEPR: deprecations log for removed issues #13777

119 of 119 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.