Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change argument name in DataFrame.drop_duplicates #734

Closed
mcobzarenco opened this issue Feb 2, 2012 · 4 comments

Comments

@mcobzarenco
Copy link

commented Feb 2, 2012

Just a tiny suggestion:
The keyword argument for specifying which columns to consider in drop_duplicates is called col_or_columns. Maybe change the name to col or to columns? Or the strangely long name is intended to make it clear that you can either pass in a label or a sequence of labels?

Thanks,
Marius

@wesm

This comment has been minimized.

Copy link
Member

commented Feb 2, 2012

Yes, the latter case. You don't actually have to pass any columns at all, which is why it's a keyword and not a positional argument. Probably naming it col is not such a big deal

@mcobzarenco

This comment has been minimized.

Copy link
Author

commented Feb 2, 2012

I know you don't need to pass in any arguments in which case it uses all
the columns.
It's only that I thought you may have called it col_or_columns such that
you remember to choose one name or the other before you commit and then
forgot :-)

Thanks,
Marius

On 2 February 2012 14:21, Wes McKinney <
reply@reply.github.com

wrote:

Yes, the latter case. You don't actually have to pass any columns at all,
which is why it's a keyword and not a positional argument. Probably naming
it col is not such a big deal


Reply to this email directly or view it on GitHub:
https://github.com/wesm/pandas/issues/734#issuecomment-3778575

@wesm

This comment has been minimized.

Copy link
Member

commented Feb 5, 2012

ok, I changed it to cols, consistent with pivot_table and other places

@mcobzarenco

This comment has been minimized.

Copy link
Author

commented Feb 6, 2012

Cool!

On 5 February 2012 00:55, Wes McKinney
reply@reply.github.com
wrote:

ok, I changed it to cols, consistent with pivot_table and other places


Reply to this email directly or view it on GitHub:
https://github.com/wesm/pandas/issues/734#issuecomment-3814715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.