Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add StringMethods.zfill #9387

Merged
merged 1 commit into from Feb 4, 2015
Merged

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Feb 1, 2015

Derived from #9111. Fixed docstring of str_pad which is inprecise.

----------
width : int
Minimum width of resulting string; additional characters will be filled
with ``fillchar``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be "filled with 0", not fillchar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake. Fixed.

@jreback jreback added Strings String extension data type and string data API Design labels Feb 2, 2015
@jreback jreback added this to the 0.16.0 milestone Feb 2, 2015
@shoyer
Copy link
Member

shoyer commented Feb 2, 2015

This looks good to me...

TomAugspurger pushed a commit that referenced this pull request Feb 4, 2015
ENH: Add StringMethods.zfill
@TomAugspurger TomAugspurger merged commit dc6592e into pandas-dev:master Feb 4, 2015
@TomAugspurger
Copy link
Contributor

Thanks @sinhrks .

@sinhrks sinhrks deleted the string_zfill branch February 4, 2015 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants