New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use set literal syntax for set prettyprinting #11215

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@flying-sheep
Contributor

flying-sheep commented Oct 1, 2015

No description provided.

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Oct 5, 2015

Contributor

pls add a test in tests/test_format.py in test_pprint

Contributor

jreback commented Oct 5, 2015

pls add a test in tests/test_format.py in test_pprint

@jreback jreback added this to the 0.17.1 milestone Oct 5, 2015

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Oct 5, 2015

Contributor

pls add a whatsnew note in 0.17.1 as well

Contributor

jreback commented Oct 5, 2015

pls add a whatsnew note in 0.17.1 as well

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Oct 9, 2015

Contributor

can you add a whatsnew note (api changes section)

Contributor

jreback commented Oct 9, 2015

can you add a whatsnew note (api changes section)

@flying-sheep

This comment has been minimized.

Show comment
Hide comment
@flying-sheep

flying-sheep Oct 9, 2015

Contributor

done

Contributor

flying-sheep commented Oct 9, 2015

done

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Oct 9, 2015

Contributor

can you add a test as well

tests/test_format.py in test_pprint

Contributor

jreback commented Oct 9, 2015

can you add a test as well

tests/test_format.py in test_pprint

@flying-sheep

This comment has been minimized.

Show comment
Hide comment
@flying-sheep

flying-sheep Oct 9, 2015

Contributor

done

Contributor

flying-sheep commented Oct 9, 2015

done

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Oct 9, 2015

Contributor

awesome. ping when green.

Contributor

jreback commented Oct 9, 2015

awesome. ping when green.

@flying-sheep

This comment has been minimized.

Show comment
Hide comment
@flying-sheep

flying-sheep Oct 10, 2015

Contributor

ping!

Contributor

flying-sheep commented Oct 10, 2015

ping!

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Oct 11, 2015

Contributor

merged via 76d4c49

thanks!

Contributor

jreback commented Oct 11, 2015

merged via 76d4c49

thanks!

@jreback jreback closed this Oct 11, 2015

@flying-sheep flying-sheep deleted the flying-sheep:patch-2 branch Oct 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment