New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Enable Index dtype comparison by default #11588

Merged
merged 1 commit into from Nov 17, 2015

Conversation

Projects
None yet
2 participants
@sinhrks
Member

sinhrks commented Nov 13, 2015

Enable check_index_type and check_columns_type by default to detect dtype related problems.

Fixed following 2 minor bugs at the same time, but I'm willing to split them to separate PR if required.

1. Series.quantile with empty list results in object index rather than float.

pd.Series([1, 2, 3]).quantile([]).index
# Index([], dtype='object')

2. pd.merge includes empty data may result in Int64Index rather than object

Sorry, #10826 was incomplete.

When fixing #11497, #11586, we can enable corresponding check_index_type

@sinhrks sinhrks added the Testing label Nov 13, 2015

@jreback jreback added this to the 0.17.1 milestone Nov 17, 2015

jreback added a commit that referenced this pull request Nov 17, 2015

Merge pull request #11588 from sinhrks/test_idxtype
TST: Enable Index dtype comparison by default

@jreback jreback merged commit e7ff318 into pandas-dev:master Nov 17, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Nov 17, 2015

Contributor

thanks!

Contributor

jreback commented Nov 17, 2015

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment