BUG: style.bar results in incorrect gradient using specific browser #11678

Merged
merged 1 commit into from Dec 10, 2015

Conversation

Projects
None yet
2 participants
Member

sinhrks commented Nov 23, 2015

It's not a bug on pandas side, but CSS linear-gradient with 0% width seems not be rendered properly using specific browsers.

Below is the output using Mac OSX 10.10.5 / Firefox.

2015-11-23 10 53 47

The fix simply exclude linear-gradient if its width is 0.

After the fix (same environment)

2015-11-23 10 54 18

sinhrks added this to the 0.18.0 milestone Nov 23, 2015

Contributor

jreback commented Nov 29, 2015

@TomAugspurger ?

@sinhrks lgtm. (prob a whatsnew conflict)

@jreback jreback and 1 other commented on an outdated diff Dec 9, 2015

doc/source/whatsnew/v0.18.0.txt
@@ -195,5 +195,9 @@ Bug Fixes
- Bug in ``.loc`` result with duplicated key may have ``Index`` with incorrect dtype (:issue:`11497`)
- Bug in ``pd.rolling_median`` where memory allocation failed even with sufficient memory (:issue:`11696`)
+- Bug in ``.loc`` against ``CategoricalIndex`` may result in normal ``Index`` (:issue:`11586`)
@jreback

jreback Dec 9, 2015

Contributor

did this extra note sneak in here?

@sinhrks

sinhrks Dec 10, 2015

Member

Thanks, removed.

@jreback jreback added a commit that referenced this pull request Dec 10, 2015

@jreback jreback Merge pull request #11678 from sinhrks/style_bar
BUG: style.bar results in incorrect gradient using specific browser
a7669d0

@jreback jreback merged commit a7669d0 into pandas-dev:master Dec 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Contributor

jreback commented Dec 10, 2015

thank you sir!

sinhrks deleted the sinhrks:style_bar branch Dec 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment