Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
BUG: remove millisecond field that raises valueerror #12019
+9
−1
Conversation
|
yeh, I think this was historicaly left in. can you add a test (assert that it raises), so when someone tries to add it back it will fail!. ping on green. |
jreback
added Timeseries API Design
labels
Jan 11, 2016
jreback
added this to the
0.18.0
milestone
Jan 11, 2016
|
Added the test, build is now passing |
jreback
added a commit
that referenced
this pull request
Jan 12, 2016
|
|
jreback |
ced5d23
|
jreback
merged commit ced5d23
into pandas-dev:master
Jan 12, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
llllllllll commentedJan 11, 2016
This would appear in the
dirand cause tab completion to a field that would raise aValueError. When I brought this up in gitter it seemed like it was safe to remove it.I couldn't find any tests that hit this descriptor.