BUG: remove millisecond field that raises valueerror #12019

Merged
merged 1 commit into from Jan 12, 2016

Conversation

Projects
None yet
2 participants
Contributor

llllllllll commented Jan 11, 2016

This would appear in the dir and cause tab completion to a field that would raise a ValueError. When I brought this up in gitter it seemed like it was safe to remove it.

I couldn't find any tests that hit this descriptor.

Contributor

jreback commented Jan 11, 2016

yeh, I think this was historicaly left in. can you add a test (assert that it raises), so when someone tries to add it back it will fail!. ping on green.

jreback added this to the 0.18.0 milestone Jan 11, 2016

Contributor

llllllllll commented Jan 12, 2016

Added the test, build is now passing

@jreback jreback added a commit that referenced this pull request Jan 12, 2016

@jreback jreback Merge pull request #12019 from llllllllll/remove-millisecond-field
BUG: remove millisecond field that raises valueerror
ced5d23

@jreback jreback merged commit ced5d23 into pandas-dev:master Jan 12, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Contributor

jreback commented Jan 12, 2016

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment