/pandas

CLN: remove core/matrix.py, not imported into the pandas namespace #12111

Merged
merged 1 commit into from Jan 21, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
  0.18.0
3 participants
@jreback @jorisvandenbossche @wesm
@jreback
Contributor

jreback commented Jan 21, 2016

No description provided.

jreback added the Clean label Jan 21, 2016

jreback added this to the 0.18.0 milestone Jan 21, 2016

@jorisvandenbossche
Owner

jorisvandenbossche commented Jan 21, 2016

+1
@jreback
Contributor

jreback commented Jan 21, 2016

I don't think this needs to be deprecated in any way.

anyone disagree?

@wesm @jorisvandenbossche
@wesm
Owner

wesm commented Jan 21, 2016

I'm +1 on removal. Deprecation warning ought to have been there in 2011 but at this point minimal users will be affected.

@jreback jreback added a commit that referenced this pull request Jan 21, 2016

@jreback jreback Merge pull request #12111 from jreback/matrix 
CLN: remove core/matrix.py, not imported into the pandas namespace
 81dfb28

@jreback jreback merged commit 81dfb28 into pandas-dev:master Jan 21, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@wesm
Owner

wesm commented Jan 21, 2016

you pushed the button!! =)
@jreback
Contributor

jreback commented Jan 21, 2016

oh right
hmm

is there a way to disable it in GitHub?
@wesm
Owner

wesm commented Jan 22, 2016

No; it's been requested many times by users, though, since in a lot of OSS projects with tighter merge protocol they've had mishaps with merges happening by accident
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment