New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Respect 'usecols' parameter even when CSV rows are uneven #12551

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@gfyoung
Member

gfyoung commented Mar 7, 2016

Closes #12203 by overriding the row alignment checks for both engines when the usecols parameter is passed into read_csv.

@jreback jreback added the IO CSV label Mar 7, 2016

@jreback jreback added this to the 0.18.1 milestone Mar 7, 2016

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Mar 9, 2016

Contributor

@gfyoung its not necessary for you to keep rebasing every time master is slightly updated.

Contributor

jreback commented Mar 9, 2016

@gfyoung its not necessary for you to keep rebasing every time master is slightly updated.

@gfyoung

This comment has been minimized.

Show comment
Hide comment
@gfyoung

gfyoung Mar 9, 2016

Member

@jreback : Oh whoops, sorry! I have a small script that updates my branches (including master in my fork) whenever I see there are commits, and I forgot to specify to just update the master branch.

Member

gfyoung commented Mar 9, 2016

@jreback : Oh whoops, sorry! I have a small script that updates my branches (including master in my fork) whenever I see there are commits, and I forgot to specify to just update the master branch.

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Mar 9, 2016

Contributor

oh ok maybe just do it manually for a while

trying to get out another rc

Contributor

jreback commented Mar 9, 2016

oh ok maybe just do it manually for a while

trying to get out another rc

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Mar 9, 2016

Contributor

the issue is that Travis runs and it can get very busy

Contributor

jreback commented Mar 9, 2016

the issue is that Travis runs and it can get very busy

@gfyoung

This comment has been minimized.

Show comment
Hide comment
@gfyoung

gfyoung Mar 9, 2016

Member

No, I perfectly understand. As a precaution, I'll add [ci skip] to all of my open PR's, since I imagine there will be changes to be made once reviewed after which I'll remove it so that Travis can run.

Member

gfyoung commented Mar 9, 2016

No, I perfectly understand. As a precaution, I'll add [ci skip] to all of my open PR's, since I imagine there will be changes to be made once reviewed after which I'll remove it so that Travis can run.

@jreback

View changes

Show outdated Hide outdated pandas/io/tests/test_parsers.py Outdated
@gfyoung

This comment has been minimized.

Show comment
Hide comment
@gfyoung

gfyoung Mar 18, 2016

Member

@jreback : Travis has no problems making CParserError inherit from ValueError, so I think this is also good to merge if there is nothing else.

Member

gfyoung commented Mar 18, 2016

@jreback : Travis has no problems making CParserError inherit from ValueError, so I think this is also good to merge if there is nothing else.

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Mar 18, 2016

Contributor

need s note in the API changes section wrt error class

Contributor

jreback commented Mar 18, 2016

need s note in the API changes section wrt error class

@gfyoung

This comment has been minimized.

Show comment
Hide comment
@gfyoung

gfyoung Mar 18, 2016

Member

Added note in the API changes. Should be good to merge if there is nothing else.

Member

gfyoung commented Mar 18, 2016

Added note in the API changes. Should be good to merge if there is nothing else.

@jreback

View changes

Show outdated Hide outdated doc/source/whatsnew/v0.18.1.txt Outdated
@jreback

View changes

Show outdated Hide outdated doc/source/whatsnew/v0.18.1.txt Outdated
@jreback

View changes

Show outdated Hide outdated pandas/io/tests/test_parsers.py Outdated
@gfyoung

This comment has been minimized.

Show comment
Hide comment
@gfyoung

gfyoung Mar 19, 2016

Member

@jreback : Made all of the requested changes. Should be ready to merge if there is nothing else.

Member

gfyoung commented Mar 19, 2016

@jreback : Made all of the requested changes. Should be ready to merge if there is nothing else.

@jreback jreback closed this in e55875e Mar 20, 2016

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Mar 20, 2016

Contributor

thanks @gfyoung

Contributor

jreback commented Mar 20, 2016

thanks @gfyoung

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment