Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR, DOC: Deprecate buffer_lines in read_csv #13360

Closed

Conversation

Projects
None yet
4 participants
@gfyoung
Copy link
Member

commented Jun 4, 2016

buffer_lines is not respected, as it is determined internally via a heuristic involving table_width (see here for how it is computed).

@gfyoung gfyoung force-pushed the forking-repos:buffer-lines-depr-doc branch Jun 4, 2016

@codecov-io

This comment has been minimized.

Copy link

commented Jun 4, 2016

Current coverage is 84.23%

Merging #13360 into master will increase coverage by <.01%

@@             master     #13360   diff @@
==========================================
  Files           138        138          
  Lines         50724      50725     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42726      42727     +1   
  Misses         7998       7998          
  Partials          0          0          

Powered by Codecov. Last updated by 103f7d3...87eff55

@@ -227,14 +227,19 @@
Note that the entire file is read into a single DataFrame regardless,
use the `chunksize` or `iterator` parameter to return the data in chunks.
(Only valid with C parser)
buffer_lines : int, default None

This comment has been minimized.

Copy link
@jreback

jreback Jun 4, 2016

Contributor

is this even used at all now?

This comment has been minimized.

Copy link
@jreback

jreback Jun 4, 2016

Contributor

it seems its not respected at all now. so we should just remove this argument (or raise if its not None)

This comment has been minimized.

Copy link
@gfyoung

gfyoung Jun 4, 2016

Author Member

Based on my PR description, nowhere. How significant of an API change would either option be?

This comment has been minimized.

Copy link
@jreback

jreback Jun 4, 2016

Contributor

well it doesn't do anything now. I guess deprecation is fine. Why don't you re-word to say it currently has no-effect.

This comment has been minimized.

Copy link
@gfyoung

gfyoung Jun 4, 2016

Author Member

Fair enough. Done.

DEPR, DOC: Deprecate buffer_lines in read_csv
The 'buffer_lines' parameter is not even respected
in the implementation, as it is determined internally
to the C parser.

[ci skip]

@gfyoung gfyoung force-pushed the forking-repos:buffer-lines-depr-doc branch to a72ecbe Jun 4, 2016

@gfyoung

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2016

@jreback : Made the requested doc change, and Travis is giving the green light. Ready to merge if there is nothing else.

@jreback jreback added this to the 0.18.2 milestone Jun 5, 2016

@jreback jreback closed this in 863cbc5 Jun 5, 2016

@jreback

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2016

ty

@jsexauer jsexauer referenced this pull request Jun 5, 2016

Open

DEPR: deprecations from prior versions #6581

0 of 98 tasks complete

@gfyoung gfyoung deleted the forking-repos:buffer-lines-depr-doc branch Jun 5, 2016

value is not respected by the parser

If ``low_memory`` is ``True``, specify the number of rows to be read for
each chunk. (Only valid with C parser)

This comment has been minimized.

Copy link
@jorisvandenbossche

jorisvandenbossche Jun 6, 2016

Member

Can't we leave out the actual explanation? As this is not only deprecated, but also does not work (IIUC), so it does not serve much purpose IMO (apart from explaining what feature exactly has never worked, and will never work ..)

BTW, @gfyoung, for the rest strong +1 on your cleaning up of the keywords!

This comment has been minimized.

Copy link
@gfyoung

gfyoung Jun 6, 2016

Author Member

@jorisvandenbossche : Will do. Thanks, for the +1 - I use this function a great deal in my own code, so I'm certainly more than happy to improve it given how much it has done for me, even in such a "broken" state. 😄

gfyoung added a commit to forking-repos/pandas that referenced this pull request Dec 19, 2017

@jreback jreback referenced this pull request Dec 19, 2017

Open

DEPR: deprecations log for removed issues #13777

116 of 116 tasks complete

jreback added a commit that referenced this pull request Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.