Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
ENH: sparse astype now supports int64 and bool #13900
Conversation
sinhrks
added Enhancement Dtypes Sparse
labels
Aug 4, 2016
sinhrks
added this to the
0.19.0
milestone
Aug 4, 2016
sinhrks
referenced
this pull request
Aug 4, 2016
Merged
ENH: Sparse int64 and bool dtype support enhancement #13849
codecov-io
commented
Aug 4, 2016
•
Current coverage is 85.29% (diff: 100%)@@ master #13900 diff @@
==========================================
Files 139 139
Lines 50057 50077 +20
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 42692 42712 +20
Misses 7365 7365
Partials 0 0
|
|
lgtm, is this dependent on anything or standalone? |
|
thx for the review. it's independent. |
jreback
closed this
in 2beab41
Aug 4, 2016
|
thanks! |
sinhrks
deleted the
sinhrks:sparse_astype branch
Aug 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sinhrks commentedAug 4, 2016
•
edited
git diff upstream/master | flake8 --diffSparseXXXnow supportastypeother thanfloat64dtype. It raisesValueErrorwhen itssp_valuesorfill_valuecannot be converted to specified dtype.Also,
fill_valuesetter now checks input value dtype and raisesValueErrorif value cannot be stored to current dtype.