Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Deprecated Index.to_datetime #14096

Merged

Conversation

Projects
None yet
3 participants
@gfyoung
Copy link
Member

commented Aug 27, 2016

Deprecates both Index.to_datetime and DatetimeIndex.to_datetime in favor of pd.to_datetime.

Partially addresses #8254.

Closes #5612 because pd.to_datetime does have a format argument.

@gfyoung gfyoung force-pushed the forking-repos:to-datetime-depr branch Aug 27, 2016

@codecov-io

This comment has been minimized.

Copy link

commented Aug 27, 2016

Current coverage is 85.27% (diff: 100%)

Merging #14096 into master will increase coverage by <.01%

@@             master     #14096   diff @@
==========================================
  Files           139        139          
  Lines         50489      50490     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43052      43053     +1   
  Misses         7437       7437          
  Partials          0          0          

Powered by Codecov. Last update 0e61847...efa9885

@gfyoung

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2016

@jorisvandenbossche : Since Travis is passing, and if there are no complaints, IMO this can be merged?

DEPR: Deprecated Index.to_datetime
Partially addresses gh-8254.
Closes gh-8612 because pd.to_datetime has a format arg.

[ci skip]

@gfyoung gfyoung force-pushed the forking-repos:to-datetime-depr branch to 5512837 Aug 27, 2016

@jorisvandenbossche

This comment has been minimized.

Copy link
Member

commented Aug 27, 2016

I would add the deprecation of Timestamp.to_datetime as well, if you are ok with that?

@gfyoung

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2016

The reasons for deprecation are slightly different though. When I looked into it, the deprecation was a little more complicated. This change, however, was relatively trivial. 😄

I would feel more comfortable doing it in a separate PR if that's okay.

@jorisvandenbossche jorisvandenbossche merged commit 670435a into pandas-dev:master Aug 27, 2016

@jorisvandenbossche

This comment has been minimized.

Copy link
Member

commented Aug 27, 2016

OK, that's fine :-) Thanks!

@jorisvandenbossche jorisvandenbossche added this to the 0.19.0 milestone Aug 27, 2016

@gfyoung

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2016

@jorisvandenbossche : Also, add that deprecation to #6581.

@gfyoung gfyoung deleted the forking-repos:to-datetime-depr branch Aug 27, 2016

@jsexauer jsexauer referenced this pull request Aug 27, 2016

Open

DEPR: deprecations from prior versions #6581

0 of 98 tasks complete
@jorisvandenbossche

This comment has been minimized.

Copy link
Member

commented Aug 27, 2016

@gfyoung yep, thanks, added

@jreback jreback referenced this pull request Aug 27, 2016

Closed

INT/CLN: remove to_datetime from class methods #8254

5 of 5 tasks complete

gfyoung added a commit to forking-repos/pandas that referenced this pull request Dec 5, 2017

CLN: Remove .to_datetime methods
Removes the following .to_datetime methods

* Index.to_datetime
* Timestamp.to_datetime
* PeriodIndex.to_datetime
* DatetimeIndex.to_datetime

All were deprecated in 0.19.0

xref pandas-devgh-8254, pandas-devgh-14096, pandas-devgh-14113

@jreback jreback referenced this pull request Dec 5, 2017

Open

DEPR: deprecations log for removed issues #13777

116 of 116 tasks complete

gfyoung added a commit to forking-repos/pandas that referenced this pull request Dec 6, 2017

CLN: Remove .to_datetime methods
Removes the following .to_datetime methods

* Index.to_datetime
* NaTType.to_datetime
* Timestamp.to_datetime
* PeriodIndex.to_datetime
* DatetimeIndex.to_datetime

All were deprecated in 0.19.0

xref pandas-devgh-8254, pandas-devgh-14096, pandas-devgh-14113

gfyoung added a commit that referenced this pull request Dec 6, 2017

CLN: Remove .to_datetime methods (#18648)
Removes the following .to_datetime methods

* Index.to_datetime
* NaTType.to_datetime
* Timestamp.to_datetime
* PeriodIndex.to_datetime
* DatetimeIndex.to_datetime

All were deprecated in 0.19.0

xref gh-8254, gh-14096, gh-14113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.