Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
DEPR: Deprecate Timestamp.to_datetime #14101
Conversation
jreback
and 1 other
commented on an outdated diff
Aug 27, 2016
codecov-io
commented
Aug 27, 2016
•
Current coverage is 85.26% (diff: 100%)@@ master #14101 diff @@
==========================================
Files 139 139
Lines 50502 50502
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43063 43062 -1
- Misses 7439 7440 +1
Partials 0 0
|
jorisvandenbossche
added the
Deprecate
label
Aug 27, 2016
jorisvandenbossche
added this to the
0.19.0
milestone
Aug 27, 2016
jreback
commented on the diff
Aug 27, 2016
pandas/tslib.pyx
| cdef: | ||
| pandas_datetimestruct dts | ||
| _TSObject ts | ||
| + | ||
| + if self.nanosecond != 0 and warn: | ||
| + warnings.warn("Discarding nonzero nanoseconds in conversion", | ||
| + UserWarning, stacklevel=2) |
jreback
Contributor
|
jreback
commented on the diff
Aug 27, 2016
doc/source/whatsnew/v0.19.0.txt
| @@ -1031,6 +1031,7 @@ Deprecations | ||
| - ``Categorical.reshape`` has been deprecated and will be removed in a subsequent release (:issue:`12882`) | ||
| - ``Series.reshape`` has been deprecated and will be removed in a subsequent release (:issue:`12882`) | ||
| +- ``Timestamp.to_datetime`` has been deprecated in favour of ``Timestamp.to_pydatetime`` (:issue:`8254`) |
|
|
gfyoung
added some commits
Aug 27, 2016
|
@jorisvandenbossche , @jreback : Travis is giving the green light, so this should be ready to merge if there are no other concerns. |
jorisvandenbossche
merged commit a9c15d3
into pandas-dev:master
Aug 29, 2016
|
@gfyoung Thanks! |
gfyoung
deleted the
gfyoung:ts-to-datetime-depr branch
Aug 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gfyoung commentedAug 27, 2016
•
edited
NaT.to_datetimeTimestamp.to_datetimeUserWarninginTimestamp.to_datetimewhen nanoseconds is non-zeroNaTis also a_Timestamp, so the second deprecation covered the first one as well.Closes #8254.