New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Deprecated PeriodIndex.to_datetime #14113

Merged
merged 2 commits into from Sep 1, 2016

Conversation

Projects
None yet
4 participants
@gfyoung
Member

gfyoung commented Aug 28, 2016

Continuation of #14096 by deprecating PeriodIndex.to_datetime in favour of PeriodIndex.to_timestamp.

Also addresses #8254.

@codecov-io

This comment has been minimized.

codecov-io commented Aug 28, 2016

Current coverage is 85.27% (diff: 100%)

Merging #14113 into master will increase coverage by <.01%

@@             master     #14113   diff @@
==========================================
  Files           139        139          
  Lines         50511      50513     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43071      43074     +3   
+ Misses         7440       7439     -1   
  Partials          0          0          

Powered by Codecov. Last update 10bf721...9fd85bb

gfyoung added some commits Aug 28, 2016

DEPR: Deprecate PeriodIndex.to_datetime.
Deprecation is in favour of PeriodIndex.to_timestamp.
@gfyoung

This comment has been minimized.

Member

gfyoung commented Sep 1, 2016

@jreback , @jorisvandenbossche : Travis is passing. Ready to merge if there are no other concerns.

@jreback

This comment has been minimized.

Contributor

jreback commented Sep 1, 2016

lgtm

@jreback jreback referenced this pull request Sep 1, 2016

Closed

INT/CLN: remove to_datetime from class methods #8254

5 of 5 tasks complete

@jorisvandenbossche jorisvandenbossche merged commit 306e647 into pandas-dev:master Sep 1, 2016

3 checks passed

codecov/patch 100% of diff hit (target 50.00%)
Details
codecov/project 85.27% (target 82.00%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jorisvandenbossche

This comment has been minimized.

Member

jorisvandenbossche commented Sep 1, 2016

Thanks!

@jorisvandenbossche jorisvandenbossche added this to the 0.19.0 milestone Sep 1, 2016

@gfyoung gfyoung deleted the forking-repos:index-to-datetime-depr-cont branch Sep 1, 2016

@gfyoung

This comment has been minimized.

Member

gfyoung commented Sep 1, 2016

Don't forget to add to the list in #6581!

@jorisvandenbossche

This comment has been minimized.

Member

jorisvandenbossche commented Sep 1, 2016

@gfyoung Already did :-) (but linked to the issue, where the links are to all the different prs)

@jsexauer jsexauer referenced this pull request Dec 5, 2017

Open

DEPR: deprecations from prior versions #6581

0 of 85 tasks complete

gfyoung added a commit to forking-repos/pandas that referenced this pull request Dec 5, 2017

CLN: Remove .to_datetime methods
Removes the following .to_datetime methods

* Index.to_datetime
* Timestamp.to_datetime
* PeriodIndex.to_datetime
* DatetimeIndex.to_datetime

All were deprecated in 0.19.0

xref pandas-devgh-8254, pandas-devgh-14096, pandas-devgh-14113

@jreback jreback referenced this pull request Dec 5, 2017

Open

DEPR: deprecations log for removed issues #13777

115 of 115 tasks complete

gfyoung added a commit to forking-repos/pandas that referenced this pull request Dec 6, 2017

CLN: Remove .to_datetime methods
Removes the following .to_datetime methods

* Index.to_datetime
* NaTType.to_datetime
* Timestamp.to_datetime
* PeriodIndex.to_datetime
* DatetimeIndex.to_datetime

All were deprecated in 0.19.0

xref pandas-devgh-8254, pandas-devgh-14096, pandas-devgh-14113

gfyoung added a commit that referenced this pull request Dec 6, 2017

CLN: Remove .to_datetime methods (#18648)
Removes the following .to_datetime methods

* Index.to_datetime
* NaTType.to_datetime
* Timestamp.to_datetime
* PeriodIndex.to_datetime
* DatetimeIndex.to_datetime

All were deprecated in 0.19.0

xref gh-8254, gh-14096, gh-14113
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment