/pandas

Remove NotImplementedError for parse_dates keyword in read_excel #14326

Closed
wants to merge 5 commits into
from

Conversation

Reviewers

@jreback jreback

Assignees
No one assigned
Labels
IO Excel
Projects
None yet
Milestone
  0.20.0
3 participants
@jorisvandenbossche @jreback @grahamjeffries
@jorisvandenbossche
Owner

jorisvandenbossche commented Sep 30, 2016

Rebase and update of PR pydata#12051

grahamjeffries and others added some commits Jan 15, 2016

@grahamjeffries @jorisvandenbossche grahamjeffries remove read_excel kwd NotImplemented error, update documentation #11544 0e10a9d
@jorisvandenbossche jorisvandenbossche Update tests

All checks have failed

1 errored and 3 failing checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch — AppVeyor build failed
Details
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/push — The Travis CI build failed
Details
925ce1b
@jorisvandenbossche jorisvandenbossche add whatsnew

All checks have failed

1 errored and 3 failing checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch — AppVeyor build failed
Details
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/push — The Travis CI build failed
Details
b1c7f87

jorisvandenbossche added the IO Excel label Sep 30, 2016

jorisvandenbossche added this to the 0.19.0 milestone Sep 30, 2016

jorisvandenbossche referenced this pull request Sep 30, 2016

Closed

remove read_excel keyword NotImplemented error, update documentation #11544 #12051

doc/source/io.rst
+
+ read_excel('path_to_file.xls', 'Sheet1', parse_dates=['date_strings'])
+
+So this should *not* be used when the column in excel has already a datetime-like
@jreback

jreback Sep 30, 2016

Contributor

small nit. I would the last part to the first paragraph you added.

somethings like. normally dates are automatically parsed. But if you have a column of 'strings' that look-like dates, you can use the parse_dates kw.

@jorisvandenbossche

jorisvandenbossche Sep 30, 2016

Owner

yep, adapted a bit

@jreback
Contributor

jreback commented Sep 30, 2016

lgtm.

jorisvandenbossche added some commits Sep 30, 2016

@jorisvandenbossche jorisvandenbossche Fix detection to raise warning

All checks have failed

1 errored and 3 failing checks
continuous-integration/travis-ci/pr — The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/branch — AppVeyor build failed
Details
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/push — The Travis CI build failed
Details
656ec44
@jorisvandenbossche jorisvandenbossche update wording

All checks have failed

4 failing checks
continuous-integration/appveyor/branch — AppVeyor build failed
Details
continuous-integration/appveyor/pr — AppVeyor build failed
Details
continuous-integration/travis-ci/pr — The Travis CI build failed
Details
continuous-integration/travis-ci/push — The Travis CI build failed
Details
0b65a7a
@jorisvandenbossche
Owner

jorisvandenbossche commented Sep 30, 2016

Apparently it does not work out of the box anymore by re-enabling it (probably due to changes in PythonParser over the last year), so will have to take a deeper look

@jorisvandenbossche jorisvandenbossche modified the milestone: 0.19.1, 0.19.0, 0.20.0 Sep 30, 2016

@jreback
Contributor

jreback commented Nov 25, 2016

@jorisvandenbossche ?
@jreback
Contributor

jreback commented Dec 30, 2016

@jorisvandenbossche let's update and get this in.
@jreback
Contributor

jreback commented Feb 27, 2017

@jorisvandenbossche can you update
@jreback
Contributor

jreback commented Mar 23, 2017

@jorisvandenbossche can you rebase

@jreback jreback added a commit to jreback/pandas that referenced this pull request Mar 27, 2017

@jorisvandenbossche @jreback jorisvandenbossche + jreback Remove NotImplementedError for parse_dates keyword in read_excel 
Rebase and update of PR pandas-dev#12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
 10d8c40

jreback closed this Mar 27, 2017

jreback referenced this pull request Mar 27, 2017

Closed

Remove NotImplementedError for parse_dates keyword in read_excel #15820

@jreback jreback added a commit that referenced this pull request Mar 27, 2017

@grahamjeffries @jreback grahamjeffries + jreback Remove NotImplementedError for parse_dates keyword in read_excel 
Rebase and update of PR #12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
 b36a461

@jreback jreback added a commit that referenced this pull request Mar 27, 2017

@grahamjeffries @jreback grahamjeffries + jreback Remove NotImplementedError for parse_dates keyword in read_excel 
Rebase and update of PR #12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
 7e43c78

@mattip mattip added a commit to mattip/pandas that referenced this pull request Apr 3, 2017

@grahamjeffries @mattip grahamjeffries + mattip Remove NotImplementedError for parse_dates keyword in read_excel 
Rebase and update of PR pandas-dev#12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
 40b4e24

@linebp linebp added a commit to linebp/pandas that referenced this pull request Apr 17, 2017

@grahamjeffries @linebp grahamjeffries + linebp Remove NotImplementedError for parse_dates keyword in read_excel 
Rebase and update of PR pandas-dev#12051

Author: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Author: Graham R. Jeffries <graham.r.jeffries@gmail.com>

This patch had conflicts when merged, resolved by
Committer: Jeff Reback <jeff@reback.net>

Closes #14326 from jorisvandenbossche/pr/12051 and squashes the following commits:

0b65a7a [Joris Van den Bossche] update wording
656ec44 [Joris Van den Bossche] Fix detection to raise warning
b1c7f87 [Joris Van den Bossche] add whatsnew
925ce1b [Joris Van den Bossche] Update tests
0e10a9d [Graham R. Jeffries] remove read_excel kwd NotImplemented error, update documentation #11544
 083f451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment