Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
ENH: support MultiIndex and tuple hashing #15224
Conversation
jreback
added Enhancement MultiIndex
labels
Jan 25, 2017
|
cc @mikegraham I separated this from the prior PR. yes my goal here is to effectively emulate |
mikegraham
referenced
this pull request
Jan 25, 2017
Closed
Steal the algorithm used to combine hashes from tupleobject.c #15227
|
@mikegraham |
codecov-io
commented
Jan 25, 2017
•
Current coverage is 86.32% (diff: 100%)@@ master #15224 diff @@
==========================================
Files 139 139
Lines 51096 51140 +44
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 44103 44148 +45
+ Misses 6993 6992 -1
Partials 0 0
|
jreback
added this to the
0.20.0
milestone
Jan 25, 2017
|
There were a couple memory improvements in 187573b over the commit as you cherry-picked it, I think. |
|
@mikegraham ahh ok, I will pick-again. thanks! |
|
@mikegraham ok fixed. Note that this obviously returns |
|
I stole the algorithm, but it's not compatible. I also iterate over the members in forward error rather than reverse...I don't think that is substantive. |
|
cc @mikegraham any final comments? |
|
We might want to do something about this behavior.
|
|
@mikegraham updated |
jreback
closed this
in c67486f
Jan 27, 2017
AnkurDedania
added a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
|
|
jreback + AnkurDedania |
4b762d1
|
jreback commentedJan 25, 2017
•
edited
on top of #15216
closes #15227