Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Don't add rowspan/colspan if it's 1. #15403
Conversation
codecov-io
commented
Feb 15, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #15403 +/- ##
==========================================
- Coverage 90.37% 90.37% -0.01%
==========================================
Files 135 135
Lines 49454 49463 +9
==========================================
+ Hits 44694 44702 +8
- Misses 4760 4761 +1
Continue to review full report at Codecov.
|
jreback
added IO HTML Output-Formatting
labels
Feb 15, 2017
|
@QuLogic thanks. Could you check and see if we have any tests of colspan > 1 when there's a MultiIndex in the columns? I see we have one for rowspan > 1 with a MI in the index, but didn't see one for the columns. |
|
I'm not sure where it is, but codecov says it's hitting both |
|
is there any visible effect of this? You can add a whatsnew entry with this PR number just to document. Maybe under Other Enhancements. lgtm. otherwise. |
|
It should be invisible to the user (other than the tables being costing
fewer KB)
…
|
jreback
added this to the
0.20.0
milestone
Feb 16, 2017
|
thanks @QuLogic |
jreback
closed this
in f65a641
Feb 17, 2017
QuLogic
deleted the
QuLogic:no-extra-span branch
Feb 18, 2017
AnkurDedania
added a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
|
|
QuLogic + AnkurDedania |
0630ba8
|
QuLogic commentedFeb 14, 2017
Just a small thing I noticed in a footnote here. Probably can't do much about the extra classes, but rowspan/colspan seem like easy fixes to save a few bytes per row/col and it's already done in the other code path.
Don't really know if this is major enough to deserve a what's new entry.
closes #xxxx- N/Agit diff upstream/master | flake8 --diff