Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
BUG: Fix nansum overflow on Windows with bottleneck #15507
Bottleneck used in nansum produces overflow error on Windows. Temporary fix that could be undone once the error in bottleneck is fixed and released, to avoid platform specificity.
@@ Coverage Diff @@ ## master #15507 +/- ## ========================================== - Coverage 91.1% 91.03% -0.07% ========================================== Files 136 136 Lines 49102 49103 +1 ========================================== - Hits 44736 44703 -33 - Misses 4366 4400 +34
The biggest issue here is this semantically changes things. IOW, now since we are always using pandas nansum (rather than bottleneck nansum if installed), we will always yield
np.nan (rather than 0 if bottleneck is installed). So I think we actually have to change this for all platforms or then this becomes even more confusing.
We indeed just need to take a decision on #9422, as we have left this lingering too long.