/pandas

BUG: Check integrity of sparse int indices #15863

Closed
wants to merge 1 commit into
from

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Sparse
Projects
None yet
Milestone
  0.20.0
3 participants
@gfyoung @codecov @jreback
@gfyoung
Member

gfyoung commented Apr 2, 2017

The check_integrity method of IntIndex in pandas.sparse was un-implemented despite having documentation. This PR implements the method and calls it when initializing IntIndex.

xref #15844 (comment)
@gfyoung gfyoung BUG: Check integrity of sparse int indices

All checks have passed

5 successful checks
ci/circleci — Your tests passed on CircleCI!
Details
@codecov
codecov/patch — Coverage not affected when comparing d1e1ba0...f435d28
Details
@codecov
codecov/project — 90.96% (target 82%)
Details
continuous-integration/appveyor/pr — AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr — The Travis CI build passed
Details
f435d28
@codecov

codecov bot commented Apr 2, 2017

Codecov Report

Merging #15863 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15863      +/-   ##
==========================================
- Coverage   90.98%   90.96%   -0.03%     
==========================================
  Files         143      143              
  Lines       49449    49449              
==========================================
- Hits        44993    44983      -10     
- Misses       4456     4466      +10
Flag Coverage Δ
#multiple 88.72% <ø> (-0.01%) ⬇️
#single 40.65% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/common.py 90.96% <0%> (-0.34%) ⬇️
pandas/core/frame.py 97.56% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e1ba0...f435d28. Read the comment docs.
@codecov

codecov bot commented Apr 2, 2017 • edited

Codecov Report

Merging #15863 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15863      +/-   ##
==========================================
- Coverage   90.98%   90.96%   -0.03%     
==========================================
  Files         143      143              
  Lines       49449    49449              
==========================================
- Hits        44993    44983      -10     
- Misses       4456     4466      +10
Flag Coverage Δ
#multiple 88.72% <ø> (-0.01%) ⬇️
#single 40.65% <ø> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.56% <0%> (-0.1%) ⬇️
pandas/tseries/index.py 95.33% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e1ba0...f435d28. Read the comment docs.

jreback added the Sparse label Apr 2, 2017

jreback added this to the 0.20.0 milestone Apr 2, 2017

@jreback
Contributor

jreback commented Apr 2, 2017

thanks!

jreback closed this in 74f527f Apr 2, 2017

gfyoung deleted the gfyoung:sparse-pyx-refactor branch Apr 2, 2017

@linebp linebp added a commit to linebp/pandas that referenced this pull request Apr 17, 2017

@gfyoung @linebp gfyoung + linebp BUG: Check integrity of sparse int indices 
The check_integrity method of IntIndex in pandas.sparse was un-
implemented despite having documentation.  This PR implements the
method and calls it when initializing `IntIndex`.    xref <a
href="https://github.com/pandas-
dev/pandas/pull/15844#discussion_r108840154">#15844 (comment)</a>

Author: gfyoung <gfyoung17@gmail.com>

Closes #15863 from gfyoung/sparse-pyx-refactor and squashes the following commits:

f435d28 [gfyoung] BUG: Check integrity of sparse int indices
 15bd3ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment