Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
BUG: Standardize malformed row handling in Python engine #15913
Conversation
| + elif 'newline inside string' in msg: | ||
| + msg = ('EOF inside string starting with ' | ||
| + 'line ' + str(kwargs['row_num'])) | ||
| + raise Exception(msg) |
gfyoung
Apr 6, 2017
•
Member
Copied from where it was originally, which according to the blame was refactored by you!
In any case, I agree: we should just remove that line and raise csv.Error now
jreback
Apr 6, 2017
Contributor
yeah csv.Error sounds fine
make a note of this in the whatsnew though
codecov
bot
commented
Apr 6, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #15913 +/- ##
==========================================
+ Coverage 90.95% 90.96% +<.01%
==========================================
Files 145 145
Lines 49534 49531 -3
==========================================
- Hits 45056 45055 -1
+ Misses 4478 4476 -2
Continue to review full report at Codecov.
|
|
@jreback : Everything is green and ready to go. |
jreback
added IO CSV Bug
labels
Apr 6, 2017
jreback
added this to the
0.20.0
milestone
Apr 6, 2017
jreback
merged commit a0b089e
into pandas-dev:master
Apr 6, 2017
5 checks passed
|
thanks @gfyoung |
gfyoung
deleted the
gfyoung:invalid-quote-skipfooter branch
Apr 6, 2017
linebp
added a commit
to linebp/pandas
that referenced
this pull request
Apr 17, 2017
|
|
gfyoung + linebp |
43eb7d6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gfyoung commentedApr 6, 2017
Wrap
next(source)whensourceis a file-buffer object to allow for more uniform error message displaying in the Python engine. Closes #15910.