Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: deprecate is_any_int_dtype and is_floating_dtype from pandas.api.types #16163

Merged
merged 3 commits into from Apr 28, 2017

Conversation

Projects
None yet
2 participants
@jreback
Copy link
Contributor

commented Apr 27, 2017

closes #16042

@jreback jreback added this to the 0.20.0 milestone Apr 27, 2017

@jsexauer jsexauer referenced this pull request Apr 27, 2017

Open

DEPR: deprecations from prior versions #6581

0 of 94 tasks complete
@codecov

This comment has been minimized.

Copy link

commented Apr 27, 2017

Codecov Report

Merging #16163 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16163      +/-   ##
==========================================
+ Coverage   90.87%   90.87%   +<.01%     
==========================================
  Files         162      162              
  Lines       50816    50826      +10     
==========================================
+ Hits        46178    46190      +12     
+ Misses       4638     4636       -2
Flag Coverage Δ
#multiple 88.66% <100%> (ø) ⬆️
#single 40.33% <66.66%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/api/types/__init__.py 100% <ø> (ø) ⬆️
pandas/core/dtypes/api.py 100% <100%> (ø) ⬆️
pandas/core/dtypes/common.py 93.5% <0%> (+0.25%) ⬆️
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075eca1...1651d74. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Apr 27, 2017

Codecov Report

Merging #16163 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16163      +/-   ##
==========================================
- Coverage   90.87%   90.85%   -0.02%     
==========================================
  Files         162      162              
  Lines       50816    50826      +10     
==========================================
  Hits        46178    46178              
- Misses       4638     4648      +10
Flag Coverage Δ
#multiple 88.63% <100%> (-0.02%) ⬇️
#single 40.33% <66.66%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/api/types/__init__.py 100% <ø> (ø) ⬆️
pandas/core/dtypes/api.py 100% <100%> (ø) ⬆️
pandas/plotting/_converter.py 63.54% <0%> (-1.82%) ⬇️
pandas/core/dtypes/common.py 93.5% <0%> (+0.25%) ⬆️
pandas/core/common.py 91.03% <0%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075eca1...6d97cfa. Read the comment docs.

@jorisvandenbossche
Copy link
Member

left a comment

You only added the is_*_dtype ones to the docs, is there a reason for that?

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2017

added the rest.

@jreback jreback merged commit b6f65eb into pandas-dev:master Apr 28, 2017

1 of 3 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

linebp added a commit to linebp/pandas that referenced this pull request May 2, 2017

DEPR: deprecate is_any_int_dtype and is_floating_dtype from pandas.ap…
…i.types (pandas-dev#16163)

* DEPR: deprecate is_any_int_dtype and is_floating_dtype from pandas.api.types

closes pandas-dev#16042

* is_ docs

pcluo added a commit to pcluo/pandas that referenced this pull request May 22, 2017

DEPR: deprecate is_any_int_dtype and is_floating_dtype from pandas.ap…
…i.types (pandas-dev#16163)

* DEPR: deprecate is_any_int_dtype and is_floating_dtype from pandas.api.types

closes pandas-dev#16042

* is_ docs

gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 27, 2018

CLN: Remove some dtype methods from API
Removes the following from the public API:

* pandas.api.types.is_sequence
* pandas.api.types.is_any_int_dtype
* pandas.api.types.is_floating_dtype

xref pandas-devgh-16163.
xref pandas-devgh-16189.

@jreback jreback referenced this pull request Oct 27, 2018

Open

DEPR: deprecations log for removed issues #13777

135 of 135 tasks complete

gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 28, 2018

CLN: Remove some dtype methods from API
Removes the following from the public API:

* pandas.api.types.is_sequence
* pandas.api.types.is_any_int_dtype
* pandas.api.types.is_floating_dtype

xref pandas-devgh-16163.
xref pandas-devgh-16189.

jreback added a commit that referenced this pull request Oct 28, 2018

CLN: Remove some dtype methods from API (#23390)
Removes the following from the public API:

* pandas.api.types.is_sequence
* pandas.api.types.is_any_int_dtype
* pandas.api.types.is_floating_dtype

xref gh-16163.
xref gh-16189.

brute4s99 added a commit to brute4s99/pandas that referenced this pull request Nov 19, 2018

CLN: Remove some dtype methods from API (pandas-dev#23390)
Removes the following from the public API:

* pandas.api.types.is_sequence
* pandas.api.types.is_any_int_dtype
* pandas.api.types.is_floating_dtype

xref pandas-devgh-16163.
xref pandas-devgh-16189.

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

CLN: Remove some dtype methods from API (pandas-dev#23390)
Removes the following from the public API:

* pandas.api.types.is_sequence
* pandas.api.types.is_any_int_dtype
* pandas.api.types.is_floating_dtype

xref pandas-devgh-16163.
xref pandas-devgh-16189.

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

CLN: Remove some dtype methods from API (pandas-dev#23390)
Removes the following from the public API:

* pandas.api.types.is_sequence
* pandas.api.types.is_any_int_dtype
* pandas.api.types.is_floating_dtype

xref pandas-devgh-16163.
xref pandas-devgh-16189.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.