Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
BUG: Fixed tput output on windows #16496
Conversation
TomAugspurger
added Output-Formatting Windows
labels
May 25, 2017
TomAugspurger
added this to the
0.20.2
milestone
May 25, 2017
codecov
bot
commented
May 25, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #16496 +/- ##
==========================================
- Coverage 90.43% 90.38% -0.05%
==========================================
Files 161 161
Lines 51045 51049 +4
==========================================
- Hits 46161 46140 -21
- Misses 4884 4909 +25
Continue to review full report at Codecov.
|
codecov
bot
commented
May 25, 2017
•
Codecov Report
@@ Coverage Diff @@
## master #16496 +/- ##
==========================================
- Coverage 90.43% 90.38% -0.05%
==========================================
Files 161 161
Lines 51045 51049 +4
==========================================
- Hits 46161 46140 -21
- Misses 4884 4909 +25
Continue to review full report at Codecov.
|
|
Any thoughts on this @jreback? I don't think it should break anything. |
|
lgtm. |
jreback
merged commit 7efc4e8
into pandas-dev:master
May 30, 2017
5 checks passed
TomAugspurger
added the
Needs Backport
label
Jun 1, 2017
TomAugspurger
added a commit
to TomAugspurger/pandas
that referenced
this pull request
Jun 1, 2017
|
|
TomAugspurger + TomAugspurger |
1669a61
|
TomAugspurger
added a commit
that referenced
this pull request
Jun 4, 2017
|
|
TomAugspurger |
e5c8224
|
TomAugspurger
removed the
Needs Backport
label
Jun 4, 2017
TomAugspurger
deleted the
TomAugspurger:shutil-terminal-size branch
Jun 4, 2017
Kiv
added a commit
to Kiv/pandas
that referenced
this pull request
Jun 11, 2017
|
|
TomAugspurger + Kiv |
44d2a12
|
stangirala
added a commit
to stangirala/pandas
that referenced
this pull request
Jun 11, 2017
|
|
TomAugspurger + stangirala |
d7fee8b
|
guillemborrell
added a commit
to guillemborrell/pandas
that referenced
this pull request
Jul 7, 2017
|
|
TomAugspurger + guillemborrell |
262cdb7
|
yarikoptic
added a commit
to neurodebian/pandas
that referenced
this pull request
Jul 12, 2017
|
|
yarikoptic |
483706d
|
TomAugspurger commentedMay 25, 2017
This came up in dask. For reasons I don't understand, you can end up with a bunch of warnings like
tput: terminal attributes: No such device or addresswhen pandas callsget_terminal_sizeI was able to monkey patch those calls with
shutil.get_terminal_sizeand verify that the warnings were fixed. However that's python3 only. This change usesshutil.get_terminal_sizewhen possible, and falls back to our prior implementation otherwise.Not sure about unit tests, but manually, the output matches on my mac.