Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Add warning for True for dropna of SeriesGroupBy.nth #17493

Merged
merged 1 commit into from Sep 12, 2017

Conversation

@tnir
Copy link
Contributor

commented Sep 11, 2017

  • deprecates undocumented params to partially addresses #11038
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
@pep8speaks

This comment has been minimized.

Copy link

commented Sep 11, 2017

Hello @tnir! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on September 12, 2017 at 08:38 Hours UTC

@tnir tnir force-pushed the tnir:groupby-nth-dropna-deprecation branch from c5058c2 to a621b7c Sep 11, 2017

@tnir tnir force-pushed the tnir:groupby-nth-dropna-deprecation branch from a621b7c to 72a8fda Sep 12, 2017

@codecov

This comment has been minimized.

Copy link

commented Sep 12, 2017

Codecov Report

Merging #17493 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17493      +/-   ##
==========================================
- Coverage   91.15%   91.13%   -0.02%     
==========================================
  Files         163      163              
  Lines       49534    49537       +3     
==========================================
- Hits        45153    45147       -6     
- Misses       4381     4390       +9
Flag Coverage Δ
#multiple 88.92% <80%> (ø) ⬆️
#single 40.22% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/core/groupby.py 92.22% <80%> (+0.01%) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.72% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46856c3...3e344b8. Read the comment docs.

@tnir tnir changed the title [WIP] DEPR: Add warning for True for dropna of SeriesGroupBy.nth DEPR: Add warning for True for dropna of SeriesGroupBy.nth Sep 12, 2017

@tnir tnir force-pushed the tnir:groupby-nth-dropna-deprecation branch from 72a8fda to 3e344b8 Sep 12, 2017

@jreback jreback added this to the 0.21.0 milestone Sep 12, 2017

@jreback jreback merged commit e682902 into pandas-dev:master Sep 12, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jreback

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2017

thanks @tnir

@jsexauer jsexauer referenced this pull request Sep 12, 2017

Open

DEPR: deprecations from prior versions #6581

0 of 89 tasks complete

@tnir tnir deleted the tnir:groupby-nth-dropna-deprecation branch Sep 12, 2017

jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Sep 23, 2017

jreback added a commit that referenced this pull request Sep 23, 2017

alanbato added a commit to alanbato/pandas that referenced this pull request Nov 10, 2017

No-Stream added a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017

No-Stream added a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017

@jreback jreback referenced this pull request Jul 1, 2019

Open

DEPR: deprecations log for removed issues #13777

141 of 141 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.