Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add mode(dropna=True) #17547

Closed
wants to merge 1 commit into from
Closed

Conversation

fulldecent
Copy link

@pep8speaks
Copy link

Hello @fulldecent! Thanks for submitting the PR.

Line 671:1: E266 too many leading '#' for block comment

@jorisvandenbossche jorisvandenbossche changed the title WIP: add set(dropna=True) WIP: add mode(dropna=True) Sep 16, 2017
@jreback
Copy link
Contributor

jreback commented Oct 29, 2017

can you rebase and update

@jreback jreback added Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Numeric Operations Arithmetic, Comparison, and Logical operations labels Oct 29, 2017
@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@c65a0f5). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #17547   +/-   ##
=========================================
  Coverage          ?    91.2%           
=========================================
  Files             ?      163           
  Lines             ?    49606           
  Branches          ?        0           
=========================================
  Hits              ?    45245           
  Misses            ?     4361           
  Partials          ?        0
Flag Coverage Δ
#multiple 88.99% <100%> (?)
#single 40.19% <75%> (?)
Impacted Files Coverage Δ
pandas/core/series.py 94.92% <100%> (ø)
pandas/core/frame.py 97.77% <100%> (ø)
pandas/core/algorithms.py 94.14% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65a0f5...87972a5. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 31, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@c65a0f5). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #17547   +/-   ##
=========================================
  Coverage          ?    91.2%           
=========================================
  Files             ?      163           
  Lines             ?    49606           
  Branches          ?        0           
=========================================
  Hits              ?    45245           
  Misses            ?     4361           
  Partials          ?        0
Flag Coverage Δ
#multiple 88.99% <100%> (?)
#single 40.19% <75%> (?)
Impacted Files Coverage Δ
pandas/core/algorithms.py 94.14% <100%> (ø)
pandas/core/series.py 94.92% <100%> (ø)
pandas/core/frame.py 97.77% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c65a0f5...87972a5. Read the comment docs.

@fulldecent
Copy link
Author

@jreback Updated and rebased.

@fulldecent
Copy link
Author

Not sure I can make it work, but I found where this should go.

@jreback
Copy link
Contributor

jreback commented Dec 28, 2017

closing as stale, if you want to work on this, pls ping.

@jreback jreback closed this Dec 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: DataFrame.mode(dropna=False)
4 participants