New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERR: Raise ImportError when xlrd is not present #17613

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@gcbeltramini
Contributor

gcbeltramini commented Sep 21, 2017

  • Related issues: #8515, #14673
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
Show outdated Hide outdated pandas/io/excel.py Outdated

@gfyoung gfyoung changed the title from Throw ImportError to ERR: Raise ImportError when xlrd is not present Sep 21, 2017

@jreback jreback added this to the 0.21.0 milestone Sep 21, 2017

@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Sep 21, 2017

Contributor

lgtm. minor comments by @gfyoung
wait for #17619 to merge

Contributor

jreback commented Sep 21, 2017

lgtm. minor comments by @gfyoung
wait for #17619 to merge

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 21, 2017

Codecov Report

Merging #17613 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17613      +/-   ##
==========================================
- Coverage   91.19%   91.17%   -0.03%     
==========================================
  Files         163      163              
  Lines       49625    49629       +4     
==========================================
- Hits        45257    45250       -7     
- Misses       4368     4379      +11
Flag Coverage Δ
#multiple 88.96% <66.66%> (-0.01%) ⬇️
#single 40.19% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/excel.py 80.37% <66.66%> (-0.18%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fedf922...dee1998. Read the comment docs.

codecov bot commented Sep 21, 2017

Codecov Report

Merging #17613 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17613      +/-   ##
==========================================
- Coverage   91.19%   91.17%   -0.03%     
==========================================
  Files         163      163              
  Lines       49625    49629       +4     
==========================================
- Hits        45257    45250       -7     
- Misses       4368     4379      +11
Flag Coverage Δ
#multiple 88.96% <66.66%> (-0.01%) ⬇️
#single 40.19% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/excel.py 80.37% <66.66%> (-0.18%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fedf922...dee1998. Read the comment docs.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 21, 2017

Codecov Report

Merging #17613 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17613      +/-   ##
==========================================
- Coverage   91.19%   91.17%   -0.03%     
==========================================
  Files         163      163              
  Lines       49625    49629       +4     
==========================================
- Hits        45257    45250       -7     
- Misses       4368     4379      +11
Flag Coverage Δ
#multiple 88.96% <66.66%> (-0.01%) ⬇️
#single 40.19% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/excel.py 80.37% <66.66%> (-0.18%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fedf922...dee1998. Read the comment docs.

codecov bot commented Sep 21, 2017

Codecov Report

Merging #17613 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17613      +/-   ##
==========================================
- Coverage   91.19%   91.17%   -0.03%     
==========================================
  Files         163      163              
  Lines       49625    49629       +4     
==========================================
- Hits        45257    45250       -7     
- Misses       4368     4379      +11
Flag Coverage Δ
#multiple 88.96% <66.66%> (-0.01%) ⬇️
#single 40.19% <0%> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/excel.py 80.37% <66.66%> (-0.18%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.77% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fedf922...dee1998. Read the comment docs.

@jreback jreback closed this in 2352fd6 Sep 22, 2017

alanbato added a commit to alanbato/pandas that referenced this pull request Nov 10, 2017

ERR: Raise ImportError when xlrd is not present
Related issues: pandas-dev#8515, pandas-dev#14673

Author: Guilherme Beltramini <guilherme.beltramini@nubank.com.br>

Closes pandas-dev#17613 from gcbeltramini/xlrd-import and squashes the following commits:

dee1998 [Guilherme Beltramini] Add PR number and blank line
c2759cb [Guilherme Beltramini] Throw ImportError

No-Stream added a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017

ERR: Raise ImportError when xlrd is not present
Related issues: pandas-dev#8515, pandas-dev#14673

Author: Guilherme Beltramini <guilherme.beltramini@nubank.com.br>

Closes pandas-dev#17613 from gcbeltramini/xlrd-import and squashes the following commits:

dee1998 [Guilherme Beltramini] Add PR number and blank line
c2759cb [Guilherme Beltramini] Throw ImportError

@gcbeltramini gcbeltramini deleted the gcbeltramini:xlrd-import branch Mar 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment