Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: passing categories or ordered kwargs to Series.astype is deprecated #17742

Merged
merged 1 commit into from Oct 3, 2017

Conversation

@jreback
Copy link
Contributor

commented Oct 2, 2017

closes #17636

@jreback jreback added this to the 0.21.0 milestone Oct 2, 2017

@jsexauer jsexauer referenced this pull request Oct 2, 2017

Open

DEPR: deprecations from prior versions #6581

0 of 89 tasks complete
@TomAugspurger
Copy link
Contributor

left a comment

Thanks.

@codecov

This comment has been minimized.

Copy link

commented Oct 2, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@a3d538a). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #17742   +/-   ##
=========================================
  Coverage          ?   91.23%           
=========================================
  Files             ?      163           
  Lines             ?    49859           
  Branches          ?        0           
=========================================
  Hits              ?    45490           
  Misses            ?     4369           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.03% <100%> (?)
#single 40.25% <50%> (?)
Impacted Files Coverage Δ
pandas/core/internals.py 94.38% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d538a...cbaa585. Read the comment docs.

@jreback jreback merged commit d944bb9 into pandas-dev:master Oct 3, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jorisvandenbossche

This comment has been minimized.

Copy link
Member

commented Oct 3, 2017

There seem to be still quite some warnings of using this in our own tests, see eg https://travis-ci.org/pandas-dev/pandas/jobs/282520540

ghost pushed a commit to reef-technologies/pandas that referenced this pull request Oct 16, 2017

alanbato added a commit to alanbato/pandas that referenced this pull request Nov 10, 2017

No-Stream added a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017

@jreback jreback referenced this pull request Jun 30, 2019

Open

DEPR: deprecations log for removed issues #13777

141 of 141 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.