New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce copying of input data on Series construction #18231

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Projects
None yet
1 participant
@jreback
Contributor

jreback commented Nov 11, 2017

closes #17449

@jreback jreback added this to the 0.22.0 milestone Nov 11, 2017

@codecov

This comment has been minimized.

codecov bot commented Nov 12, 2017

Codecov Report

Merging #18231 into master will decrease coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18231      +/-   ##
==========================================
- Coverage   91.43%   91.38%   -0.05%     
==========================================
  Files         163      163              
  Lines       50091    50099       +8     
==========================================
- Hits        45800    45784      -16     
- Misses       4291     4315      +24
Flag Coverage Δ
#multiple 89.19% <83.33%> (-0.03%) ⬇️
#single 40.39% <42.59%> (-0.04%) ⬇️
Impacted Files Coverage Δ
pandas/core/indexes/timedeltas.py 91.17% <100%> (ø) ⬆️
pandas/core/indexes/period.py 92.91% <100%> (+0.02%) ⬆️
pandas/core/dtypes/cast.py 88.39% <71.42%> (+0.22%) ⬆️
pandas/core/indexes/base.py 96.42% <87.5%> (ø) ⬆️
pandas/core/indexes/datetimes.py 95.48% <87.5%> (ø) ⬆️
pandas/core/series.py 94.82% <90.9%> (-0.19%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.38% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/core/internals.py 94.47% <0%> (-0.08%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96a5274...5f4a297. Read the comment docs.

@codecov

This comment has been minimized.

codecov bot commented Nov 12, 2017

Codecov Report

Merging #18231 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18231      +/-   ##
==========================================
- Coverage   91.36%   91.32%   -0.05%     
==========================================
  Files         164      164              
  Lines       49718    49726       +8     
==========================================
- Hits        45426    45410      -16     
- Misses       4292     4316      +24
Flag Coverage Δ
#multiple 89.12% <100%> (-0.03%) ⬇️
#single 39.63% <70.83%> (-0.05%) ⬇️
Impacted Files Coverage Δ
pandas/core/series.py 94.84% <100%> (-0.19%) ⬇️
pandas/core/dtypes/cast.py 88.39% <100%> (+0.22%) ⬆️
pandas/core/indexes/datetimes.py 95.48% <100%> (ø) ⬆️
pandas/core/indexes/timedeltas.py 91.14% <100%> (ø) ⬆️
pandas/core/indexes/period.py 92.92% <100%> (+0.02%) ⬆️
pandas/core/indexes/base.py 96.43% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.44% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.8% <0%> (-0.1%) ⬇️
pandas/core/internals.py 94.47% <0%> (-0.08%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8486c73...f5cb71f. Read the comment docs.

@jreback

This comment has been minimized.

Contributor

jreback commented Nov 13, 2017

@TomAugspurger @jorisvandenbossche

this is a slight API change (and a bug fix), but was needed to conform Series creation a bit.

@jreback jreback merged commit 8512cc5 into pandas-dev:master Nov 21, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment