Join GitHub today
ENH: allow get_dummies to accept dtype argument #18330
Update in version 0.19.0 made
In my case there was serious performance degradation between versions 0.18 and 0.19. After investigation, reason behind it turned out to be the change to
Apart from performance considerations, I can imagine
I've extended the test suite to run all the
@@ Coverage Diff @@ ## master #18330 +/- ## ========================================== - Coverage 91.35% 91.33% -0.02% ========================================== Files 163 163 Lines 49714 49719 +5 ========================================== - Hits 45415 45410 -5 - Misses 4299 4309 +10
looks good generally. thanks for parametrizing the tests!
I'll finish taking a look later but my only real concern is how many times you parametrize by the dtype. It's great to do that for some tests like
test_basic_dtype and a few others, but I'm not sure about all the prefix / sep tests. Do you have specific concerns that you're trying to test there?
Gave another quick glance, and things look good here.
lgtm. small doc changes. have a look in reshaping.rst if any doc updates are needed.