New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json_normalize: Make code more pythonic and avoid modification of meta if mutable #18610

Merged
merged 3 commits into from Dec 4, 2017

Conversation

Projects
None yet
3 participants
@davidfischer-ch
Contributor

davidfischer-ch commented Dec 3, 2017

  • closes itself #18610

  • tests added / passed

  • passes git diff master -u -- "*.py" | flake8 --diff

  • whatsnew entry

  • Update json_normalize to prevent modifying meta parameter.

  • Make the code more Pythonic too.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 3, 2017

Codecov Report

Merging #18610 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18610      +/-   ##
==========================================
- Coverage   91.46%   91.45%   -0.02%     
==========================================
  Files         157      157              
  Lines       51439    51447       +8     
==========================================
- Hits        47051    47049       -2     
- Misses       4388     4398      +10
Flag Coverage Δ
#multiple 89.32% <100%> (-0.01%) ⬇️
#single 40.6% <0%> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/json/normalize.py 96.87% <100%> (-0.07%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️
pandas/io/parsers.py 95.55% <0%> (-0.05%) ⬇️
pandas/core/indexes/multi.py 96.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e16818...79892a0. Read the comment docs.

codecov bot commented Dec 3, 2017

Codecov Report

Merging #18610 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18610      +/-   ##
==========================================
- Coverage   91.46%   91.45%   -0.02%     
==========================================
  Files         157      157              
  Lines       51439    51447       +8     
==========================================
- Hits        47051    47049       -2     
- Misses       4388     4398      +10
Flag Coverage Δ
#multiple 89.32% <100%> (-0.01%) ⬇️
#single 40.6% <0%> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/io/json/normalize.py 96.87% <100%> (-0.07%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️
pandas/io/parsers.py 95.55% <0%> (-0.05%) ⬇️
pandas/core/indexes/multi.py 96.28% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e16818...79892a0. Read the comment docs.

@jreback

can you add a whatsnew not for 0.21.1

Show outdated Hide outdated pandas/tests/io/json/test_normalize.py

@jreback jreback added this to the 0.21.1 milestone Dec 3, 2017

@davidfischer-ch

This comment has been minimized.

Show comment
Hide comment
@davidfischer-ch

davidfischer-ch Dec 4, 2017

Contributor

@jreback is it OK now? Thanks.

Contributor

davidfischer-ch commented Dec 4, 2017

@jreback is it OK now? Thanks.

@jreback

jreback approved these changes Dec 4, 2017

@jreback jreback merged commit 2c903d5 into pandas-dev:master Dec 4, 2017

0 of 2 checks passed

ci/circleci Your tests are queued behind your running builds
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@jreback

This comment has been minimized.

Show comment
Hide comment
@jreback

jreback Dec 4, 2017

Contributor

thanks!

Contributor

jreback commented Dec 4, 2017

thanks!

TomAugspurger added a commit to TomAugspurger/pandas that referenced this pull request Dec 8, 2017

TomAugspurger added a commit that referenced this pull request Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment