Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR/CLN: Remove how keyword from df.rolling() etc. #18668

Merged
merged 1 commit into from Dec 8, 2017

Conversation

Projects
None yet
3 participants
@topper-123
Copy link
Contributor

commented Dec 6, 2017

  • xref #18601 and #11603
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

The how parameter of df.rolling/expanding/ewm related methods was deprecated in 0.18 (#11603). This PR removes the parameter from the code base.

This PR is a continuation of #18601 (removed the freq parameter). Next up will be to remove pd.stats.*).

@topper-123 topper-123 force-pushed the topper-123:remove_rolling_etc_how branch 2 times, most recently from 146918d to 32bf255 Dec 6, 2017


indices = [datetime(1975, 1, i) for i in range(1, 6)]
# So that we can have 3 datapoints on last day (4, 10, and 20)
indices.append(datetime(1975, 1, 5, 1))

This comment has been minimized.

Copy link
@jreback

jreback Dec 7, 2017

Contributor

just remove the actual how= params, the rest of the tests are ok (you can rename this slightly as well). its possible these tests are somewhat duplicated as well. have a look.

This comment has been minimized.

Copy link
@topper-123

topper-123 Dec 7, 2017

Author Contributor

I think these test look a bit contrieved then ATM, but ok, I will look into them when I refactor pd.stats to see if it makes sense to keep them, possibly in an altered shape.

@jreback jreback referenced this pull request Dec 7, 2017

Open

DEPR: deprecations log for removed issues #13777

116 of 116 tasks complete
@codecov

This comment has been minimized.

Copy link

commented Dec 7, 2017

Codecov Report

Merging #18668 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18668      +/-   ##
==========================================
- Coverage   91.59%   91.55%   -0.05%     
==========================================
  Files         153      153              
  Lines       51212    51212              
==========================================
- Hits        46908    46887      -21     
- Misses       4304     4325      +21
Flag Coverage Δ
#multiple 89.41% <100%> (-0.03%) ⬇️
#single 40.67% <50%> (-0.11%) ⬇️
Impacted Files Coverage Δ
pandas/core/window.py 96.31% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/plotting/_converter.py 63.44% <0%> (-1.82%) ⬇️
pandas/core/frame.py 97.81% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 695e893...2f4ba4e. Read the comment docs.

@topper-123 topper-123 force-pushed the topper-123:remove_rolling_etc_how branch from 32bf255 to 2f4ba4e Dec 7, 2017

@topper-123

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2017

All green.

@jreback jreback added this to the 0.22.0 milestone Dec 8, 2017

@jreback

jreback approved these changes Dec 8, 2017

@jreback jreback merged commit a7f6714 into pandas-dev:master Dec 8, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jreback

This comment has been minimized.

Copy link
Contributor

commented Dec 8, 2017

thanks @topper-123

- The ``freq`` parameter has been removed from the ``rolling``/``expanding``/``ewm`` methods of DataFrame
and Series (deprecated since v0.18). Instead, resample before calling the methods. (:issue:18601)
- The ``freq`` and ``how`` parameters have been removed from the ``rolling``/``expanding``/``ewm`` methods of DataFrame
and Series (deprecated since v0.18). Instead, resample before calling the methods. (:issue:18601 & :issue:18668)

This comment has been minimized.

Copy link
@jorisvandenbossche

jorisvandenbossche Dec 8, 2017

Member

@topper-123 small note for future reference: the issue references need some backticks (see eg line above)

@topper-123 topper-123 deleted the topper-123:remove_rolling_etc_how branch Dec 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.