BUG: Pass kwargs from Index.to_series to pd.Series #18707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #18707 +/- ##
==========================================
+ Coverage 91.58% 91.59% +<.01%
==========================================
Files 153 153
Lines 51305 51315 +10
==========================================
+ Hits 46989 47000 +11
+ Misses 4316 4315 -1
Continue to review full report at Codecov.
|
jreback
requested changes
Dec 10, 2017
| @@ -994,9 +994,13 @@ def to_series(self, **kwargs): | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
instead of this, simply list the kwargs that we accept, name=None, index=None and pass them thru.
pandas/core/indexes/datetimes.py
Outdated
| @@ -928,7 +928,7 @@ def _get_time_micros(self): | |||
| values = self._local_timestamps() | |||
| return fields.get_time_micros(values) | |||
|
|
|||
| def to_series(self, keep_tz=False): | |||
| def to_series(self, keep_tz=False, **kwargs): | |||
| assert s.values is not idx.values | ||
| assert s.index is idx | ||
| assert s.name == idx.name | ||
|
|
doc/source/whatsnew/v0.22.0.txt
Outdated
| @@ -188,7 +188,8 @@ Other API Changes | |||
| - :func:`pandas.DataFrame.merge` no longer casts a ``float`` column to ``object`` when merging on ``int`` and ``float`` columns (:issue:`16572`) | |||
| - The default NA value for :class:`UInt64Index` has changed from 0 to ``NaN``, which impacts methods that mask with NA, such as ``UInt64Index.where()`` (:issue:`18398`) | |||
| - Refactored ``setup.py`` to use ``find_packages`` instead of explicitly listing out all subpackages (:issue:`18535`) | |||
| - Rearranged the order of keyword arguments in :func:`read_excel()` to align with :func:`read_csv()` (:pr:`16672`) | |||
| - Rearranged the order of keyword arguments in :func:`read_excel()` to align with :func:`read_csv()` (:issue:`16672`) | |||
| - :func:`DatetimeIndex.to_series` now allows kwargs which are passed to :class:`Series` constructor (:issue:`18699`) | |||
There was a problem hiding this comment.
just same we now only accept kwargs name,index :func;`Index..to_series`
There was a problem hiding this comment.
actually, make this in the bug-fix section and not here
jreback
added
Bug
Indexing
alysivji
force-pushed
the
issue_18699
branch
from
d53b7aa
to
ec05208
Compare
|
Completed requested changes and rebased. |
|
@jreback Changes have been made. Anything else that needs to be done? |
jreback
approved these changes
Dec 13, 2017
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffPlease let me know if you have any questions