New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Deprecate skip_footer in read_excel #18836

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
2 participants
@gfyoung
Member

gfyoung commented Dec 19, 2017

For consistency with read_csv, which uses skipfooter.

DEPR: Deprecate skip_footer in read_excel
For consistency with read_csv, which uses skipfooter.

@gfyoung gfyoung added this to the 0.22.0 milestone Dec 19, 2017

@gfyoung gfyoung changed the title from DEPR: Deprecate skip_footer in read_excel [skip ci] to DEPR: Deprecate skip_footer in read_excel Dec 19, 2017

@codecov

This comment has been minimized.

codecov bot commented Dec 19, 2017

Codecov Report

Merging #18836 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18836      +/-   ##
==========================================
- Coverage   91.64%   91.62%   -0.02%     
==========================================
  Files         154      154              
  Lines       51408    51406       -2     
==========================================
- Hits        47113    47101      -12     
- Misses       4295     4305      +10
Flag Coverage Δ
#multiple 89.49% <100%> (-0.01%) ⬇️
#single 40.84% <100%> (-0.12%) ⬇️
Impacted Files Coverage Δ
pandas/io/excel.py 90.09% <100%> (-0.04%) ⬇️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.68% <0%> (-0.11%) ⬇️
pandas/core/indexes/datetimes.py 95.62% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6a7cc9...7045d51. Read the comment docs.

@jsexauer jsexauer referenced this pull request Dec 19, 2017

Open

DEPR: deprecations from prior versions #6581

0 of 82 tasks complete

@jreback jreback merged commit 0c07ab2 into pandas-dev:master Dec 19, 2017

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jreback

This comment has been minimized.

Contributor

jreback commented Dec 19, 2017

thanks!

@gfyoung gfyoung deleted the forking-repos:excel-skipfooter-deprecate branch Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment