Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix DTI comparison with None, datetime.date #19301
referenced this pull request
Jan 19, 2018
@@ Coverage Diff @@ ## master #19301 +/- ## ======================================= Coverage 91.67% 91.67% ======================================= Files 148 148 Lines 48553 48553 ======================================= Hits 44513 44513 Misses 4040 4040
OK. There are no such tests in this file; possible in scalar. My first choice is to not move anything in this PR, but if we have to either move DTI-with-timestamp-comparison test to tests.scalar or timestamp-with-DTI-comparison test to tests.indexes, I'd prefer the latter.
This was referenced
Jan 30, 2018
@jbrockmendel just wanted to say. very much appreciate your changes. As they get more complicated and/or hit edge cases, I am necessarily being more of a stickler on things. don't take it personally (and you are very responsive!)
pandas is quite complicated and enforcing consistency across user AND developer experiences is hard, but very important.