New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing tests, fix offset floordiv, rfloordiv, fix return types #19738

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@jbrockmendel
Member

jbrockmendel commented Feb 17, 2018

This splits off of #19365 a bunch of peripheral changes that were never intended to be part of #19365 in the first place.

  • Implements many tests in the "how is there not already a test for that!?" category

  • Fixes(+tests) Timedelta // DateOffset and DateOffset // Timedelta

  • Fixes(+tests) return types for Timedelta.__add__, __radd__, __sub__, __rsub__(np.timedelta64) (ATM returns timedelta64)

  • Fixes a typo in test_construction that causes a dummy assertion to be made instead of the intended assertion.

  • closes #xxxx

  • tests added / passed

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

  • whatsnew entry

jbrockmendel added some commits Feb 17, 2018

@codecov

This comment has been minimized.

codecov bot commented Feb 17, 2018

Codecov Report

Merging #19738 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19738      +/-   ##
==========================================
+ Coverage   91.58%   91.61%   +0.02%     
==========================================
  Files         150      150              
  Lines       48862    48862              
==========================================
+ Hits        44750    44763      +13     
+ Misses       4112     4099      -13
Flag Coverage Δ
#multiple 89.98% <ø> (+0.02%) ⬆️
#single 41.75% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/ops.py 97.01% <0%> (+0.17%) ⬆️
pandas/plotting/_converter.py 66.95% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44c822d...edcd7e0. Read the comment docs.

@@ -13,6 +16,135 @@
class TestTimedeltaArithmetic(object):

This comment has been minimized.

@jreback

jreback Feb 18, 2018

Contributor

as I said in another PR, pls create a

pandas/tests/scalar/timedelta/test_arithmetic to add these 2

This comment has been minimized.

@jreback

jreback Feb 18, 2018

Contributor

let's do that first so that its then easier to see the changes in this.

This comment has been minimized.

@jbrockmendel

jbrockmendel Feb 18, 2018

Member

OK. Will open a new PR that just moves tests without making any actual changes.

This comment has been minimized.

@jbrockmendel

jbrockmendel Feb 18, 2018

Member

Edit: it will add tests that currently pass, will not remove any existing tests or touch anything outside of the tests.

@jbrockmendel

This comment has been minimized.

Member

jbrockmendel commented Feb 19, 2018

Closing n favor of #19752 plus followups

@jbrockmendel jbrockmendel deleted the jbrockmendel:tdfixes2 branch Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment