Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
DEPR: remove pandas.core.common is_* #19769
Ah, I see. In that cause, probably best to just remove. I would split that off into it's own subitem in the release notes though (we could also add it to pandas_compat, right?).…
On Mon, Feb 19, 2018 at 2:35 PM, Joris Van den Bossche < ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In doc/source/whatsnew/v0.23.0.txt <#19769 (comment)>: > @@ -624,6 +624,7 @@ Removal of prior version deprecations/changes - The modules `pandas.tools.hashing` and `pandas.util.hashing` have been removed (:issue:`16223`) - The top-level functions ``pd.rolling_*``, ``pd.expanding_*`` and ``pd.ewm*`` have been removed (Deprecated since v0.18). Instead, use the DataFrame/Series methods :attr:`~DataFrame.rolling`, :attr:`~DataFrame.expanding` and :attr:`~DataFrame.ewm` (:issue:`18723`) +- Imports from ``pandas.core.common`` for api like functions such as ``is_datetime64_dtype`` are now removed. These are located in ``pandas.api.types``. Furthermore, errors are removed as well from ``pandas.core.common`` and are available in ``pandas.errors`` (:issue:`13990`) I think the only way this can really be solved is by renaming core/common.py to eg core/utils.py, and then you can deprecate the whole core/common.py module, and already raise warning on importing it. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#19769 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABQHIrRypQg_tMPT3DGCGcQi0w5F1Mojks5tWdslgaJpZM4SK5Eh> .
@@ Coverage Diff @@ ## master #19769 +/- ## ========================================== - Coverage 91.61% 91.57% -0.05% ========================================== Files 150 150 Lines 48887 48865 -22 ========================================== - Hits 44786 44746 -40 - Misses 4101 4119 +18
Feb 22, 2018
referenced this pull request
Feb 22, 2018
pushed a commit
this pull request
Feb 28, 2018
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews.