parametrize a whole mess of tests #19785
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19785 +/- ##
==========================================
+ Coverage 91.61% 91.61% +<.01%
==========================================
Files 150 150
Lines 48887 48882 -5
==========================================
- Hits 44786 44782 -4
+ Misses 4101 4100 -1
Continue to review full report at Codecov.
|
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
looks good, just a couple of comments
| self.assert_index_parameters(new_index) | ||
|
|
||
| def test_join_with_period_index(self): | ||
| @pytest.mark.parametrize('how', ['left', 'right', 'inner', 'outer']) |
There was a problem hiding this comment.
note to make a fixture and hence conform ordering of how
| for tz in [None, 'UTC', 'US/Eastern', 'Asia/Tokyo']: | ||
| base = pd.date_range('2016-11-05', freq='H', periods=100, tz=tz) | ||
| idx = base.repeat(5) | ||
| @pytest.mark.parametrize('tz', [None, 'UTC', 'US/Eastern', 'Asia/Tokyo']) |
There was a problem hiding this comment.
usual note to fixturize tz (in future)
|
|
||
| msg = r"unsupported operand type\(s\)" | ||
|
|
||
| for obj in [idx, ser]: |
There was a problem hiding this comment.
still need this loop here?
There was a problem hiding this comment.
There are a bunch of borderline cases like this left for the next pass.
| assert p.tz == exp.tz | ||
|
|
||
| def test_timestamp_tz_arg_dateutil(self): | ||
| @pytest.mark.parametrize('case', ['Europe/Brussels', |
| assert p.tz == exp_zone.tzinfo | ||
| assert p.tz == exp.tz | ||
|
|
||
| @pytest.mark.parametrize('case', ['dateutil/Europe/Brussels', |
There was a problem hiding this comment.
There's already a tz variable in the method; case is the name used for this in the status quo.
There was a problem hiding this comment.
pls change. this is really confusing.
jreback
added
Testing
|
thanks. pls add to the list to move the common fixtures to a higher level (e.g. tz, dtypes) |
2 participants
What it says on the tin. Because this is a big diff, nothing is moved or changed other than parametrizing tests.