New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Timedelta.__mul__(NaT) #19819

Merged
merged 2 commits into from Feb 22, 2018

Conversation

Projects
None yet
2 participants
@jbrockmendel
Member

jbrockmendel commented Feb 21, 2018

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

jbrockmendel added some commits Feb 21, 2018

@codecov

This comment has been minimized.

codecov bot commented Feb 21, 2018

Codecov Report

Merging #19819 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19819   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files         150      150           
  Lines       48892    48892           
=======================================
  Hits        44792    44792           
  Misses       4100     4100
Flag Coverage Δ
#multiple 89.99% <ø> (ø) ⬆️
#single 41.79% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa59954...7d0d558. Read the comment docs.

def test_td_mul_nat(self, op, td_nat):
# GH#19819
td = Timedelta(10, unit='d')
with pytest.raises(TypeError):

This comment has been minimized.

@jreback

jreback Feb 22, 2018

Contributor

why do we raise on this again? what is the behavior on divide?

This comment has been minimized.

@jbrockmendel

jbrockmendel Feb 22, 2018

Member

For the same reason we raise on Timedelta * timedelta (or Timedelta * datetime depending on what hat pd.NaT is wearing).

For division Timedelta / pd.NaT returns np.nan, which is already correct.

@jreback jreback added this to the 0.23.0 milestone Feb 22, 2018

@jreback jreback merged commit 399a96b into pandas-dev:master Feb 22, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jreback

This comment has been minimized.

Contributor

jreback commented Feb 22, 2018

thanks

harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018

@jbrockmendel jbrockmendel deleted the jbrockmendel:tdfixes6 branch Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment