New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rfloordiv return type, un-xfail Timedelta tests #19820

Merged
merged 3 commits into from Feb 22, 2018

Conversation

Projects
None yet
2 participants
@jbrockmendel
Member

jbrockmendel commented Feb 21, 2018

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
@codecov

This comment has been minimized.

codecov bot commented Feb 21, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@b585e3b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #19820   +/-   ##
=========================================
  Coverage          ?   91.58%           
=========================================
  Files             ?      150           
  Lines             ?    48892           
  Branches          ?        0           
=========================================
  Hits              ?    44780           
  Misses            ?     4112           
  Partials          ?        0
Flag Coverage Δ
#multiple 89.96% <ø> (?)
#single 41.79% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b585e3b...8b2f38e. Read the comment docs.

@jreback

doc comment. ping when pushed.

@@ -744,6 +744,7 @@ Timedelta
- Bug in :func:`Timedelta.__floordiv__`, :func:`Timedelta.__rfloordiv__` where operating with a ``Tick`` object would raise a ``TypeError`` instead of returning a numeric value (:issue:`19738`)
- Bug in :func:`Period.asfreq` where periods near ``datetime(1, 1, 1)`` could be converted incorrectly (:issue:`19643`)
- Bug in :func:`Timedelta.total_seconds()` causing precision errors i.e. ``Timedelta('30S').total_seconds()==30.000000000000004`` (:issue:`19458`)
- Bug in :func: `Timedelta.__rmod__` where operating with a ``numpy.timedelta64`` returned a ``timedelta64`` object instead of a ``Timedelta`` (:issue:`19378`)

This comment has been minimized.

@jreback

jreback Feb 22, 2018

Contributor

this is not the correct reference, can you update?

@jreback jreback added this to the 0.23.0 milestone Feb 22, 2018

@jreback

This comment has been minimized.

Contributor

jreback commented Feb 22, 2018

needs rebase actually. ping on green.

@jreback jreback merged commit ca27ee9 into pandas-dev:master Feb 22, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
ci/circleci Your tests passed on CircleCI!
Details
@jreback

This comment has been minimized.

Contributor

jreback commented Feb 22, 2018

thanks

harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018

@jbrockmendel jbrockmendel deleted the jbrockmendel:tdfixes5 branch Jun 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment