Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: dtype=object should stop conversion from object in frame constructo... #2291

Merged
merged 3 commits into from Nov 24, 2012

Conversation

@changhiskhan
Copy link
Contributor

commented Nov 19, 2012

...r #2255

don't call maybe_convert_objects in _convert_object_array if dtype is object.

Note that it also stops other type conversions too.

@ghost

This comment has been minimized.

Copy link

commented Nov 19, 2012

It's better to add new keyword arguments at the end of the arglist,
or you risk breaking existing code:

In [2]: def f(a,b=1):
   ...:    print b
   ...: 
   ...: f(0,'b')
   ...: 
b

In [3]: def f(a,c=2,b=1):
   ...:    print b
   ...: 
   ...: f(0,'b')
1

@wesm wesm merged commit b5ea387 into pandas-dev:master Nov 24, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.