Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove offset/DTI caching (disabled since 0.14 #23118

Merged
merged 6 commits into from Oct 14, 2018

Conversation

Projects
None yet
3 participants
@jbrockmendel
Copy link
Member

commented Oct 13, 2018

  • closes #23080
  • tests added / passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry
@pep8speaks

This comment has been minimized.

Copy link

commented Oct 13, 2018

Hello @jbrockmendel! Thanks for submitting the PR.

jbrockmendel added some commits Oct 13, 2018

@codecov

This comment has been minimized.

Copy link

commented Oct 13, 2018

Codecov Report

Merging #23118 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23118      +/-   ##
==========================================
+ Coverage   92.13%   92.14%   +0.01%     
==========================================
  Files         170      170              
  Lines       51078    51016      -62     
==========================================
- Hits        47061    47009      -52     
+ Misses       4017     4007      -10
Flag Coverage Δ
#multiple 90.56% <100%> (ø) ⬆️
#single 42.3% <37.5%> (+0.02%) ⬆️
Impacted Files Coverage Δ
pandas/tseries/offsets.py 97.27% <ø> (-0.01%) ⬇️
pandas/core/indexes/datetimes.py 96.49% <100%> (+0.85%) ⬆️
pandas/core/arrays/datetimes.py 97.38% <100%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f05cc8...6f5648f. Read the comment docs.

@jreback

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2018

I agree this is nice to remove. but just to be sure, can you run an asv on date/time types and check that it is really not used anywhere.

@jreback jreback added this to the 0.24.0 milestone Oct 14, 2018

@jreback

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2018

also add a whatsnew note (put in api breaking changes, even though it has long been disabled)

@jbrockmendel

This comment has been minimized.

Copy link
Member Author

commented Oct 14, 2018

also add a whatsnew note (put in api breaking changes, even though it has long been disabled)

OK. What do I say has changed?

@jreback

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2018

just say that the attribute has been removed; it’s just a notice that a change was made (though is not actually public folks sometimes rely on this)

jbrockmendel added some commits Oct 14, 2018

@jbrockmendel

This comment has been minimized.

Copy link
Member Author

commented Oct 14, 2018

just say that the attribute has been removed

Done. asvs showed no change.

@jreback

This comment has been minimized.

Copy link
Contributor

commented Oct 14, 2018

lgtm merge on green

@jbrockmendel jbrockmendel merged commit a0ca4d7 into pandas-dev:master Oct 14, 2018

6 checks passed

ci/circleci: py27_compat Your tests passed on CircleCI!
Details
ci/circleci: py35_ascii Your tests passed on CircleCI!
Details
ci/circleci: py36_locale Your tests passed on CircleCI!
Details
ci/circleci: py36_locale_slow Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20181014.21 succeeded
Details

@jbrockmendel jbrockmendel deleted the jbrockmendel:nocache branch Oct 14, 2018

brute4s99 added a commit to brute4s99/pandas that referenced this pull request Nov 19, 2018

Remove offset/DTI caching (disabled since 0.14 (pandas-dev#23118)
* Remove offset/DTI caching (disabled since 0.14

* remove unused import

* remove cached_range tests

* fixup remove unused imports

* whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.