Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #1000, to_string(), to_html() should respect col_space #2328

Merged
merged 5 commits into from Nov 29, 2012

Conversation

@ghost
Copy link

commented Nov 22, 2012

Note that the semantics of col_space are different in each case, characters vs. pixels,
but that's reasonable.

I hope this doesn't presage more html configuration via kwd arguments, yonder way
madness lies.

also, there's a discrepency between the docstring and io.rst (github doesn't seem to jump to the right line)
the first defines it as the width of the columns, the latter as the number of spaces between columns,
I adopted the former, since space between columns does not translate as easily to html.

sigh, also, colSpace has already been deprecated in favor of col_space, so
I would feel bad about deprecating col_space in favor of min_col_width.
I'll leave that decision to braver, fearless souls.

closes #1000.

@ghost

This comment has been minimized.

Copy link
Author

commented Nov 22, 2012

oops, breakage.

y-p added 5 commits Nov 22, 2012
y-p
DOC: change definition of col_space.
wasn't implemented till now, so shouldn't break anything.
colSpace was already deprecated in favor of col_space, so
I would feel bad about deprecating col_space in favor of
min_col_width.
@ghost

This comment has been minimized.

Copy link
Author

commented Nov 22, 2012

Travis is experiencing weirdness with numpy on py3, tox runs clean for me on 3.2.

@wesm

This comment has been minimized.

Copy link
Member

commented Nov 22, 2012

Yeah what's going on with that? hopefully transient

@wesm wesm merged commit efe48a5 into pandas-dev:master Nov 29, 2012

@wesm

This comment has been minimized.

Copy link
Member

commented Nov 29, 2012

Merged this, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.