Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REF/TST: Add more pytest idiom to parsers tests #23761

Merged
merged 1 commit into from Nov 18, 2018

Conversation

Projects
None yet
4 participants
@gfyoung
Copy link
Member

commented Nov 18, 2018

Adds more idiom to the following:

  • parser/comment --> parser/test_comment
  • parser/converters --> parser/test_converters
  • parser/compression --> parser/test_compression
  • parser/dialect --> parser/test_dialect

Builds off of #23712.

In the interest of keeping the diff somewhat manageable, I only modified these four (i.e. we can't get rid of test_parsers.py yet), so we're still in this weird intermediary state, but that's fine.

@gfyoung gfyoung added this to the 0.24.0 milestone Nov 18, 2018

@pep8speaks

This comment has been minimized.

Copy link

commented Nov 18, 2018

Hello @gfyoung! Thanks for submitting the PR.

REF/TST: Add more pytest idiom to parsers tests
Adds more idiom to the following:

* parser/comment --> parser/test_comment
* parser/converters --> parser/test_converters
* parser/compression --> parser/test_compression
* parser/dialect --> parser/test_dialect

Builds off of gh-23712.

@gfyoung gfyoung force-pushed the forking-repos:pytest-parsers-idiom branch from d2f762b to f6d291e Nov 18, 2018

@codecov

This comment has been minimized.

Copy link

commented Nov 18, 2018

Codecov Report

Merging #23761 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23761   +/-   ##
=======================================
  Coverage   92.23%   92.23%           
=======================================
  Files         161      161           
  Lines       51408    51408           
=======================================
  Hits        47416    47416           
  Misses       3992     3992
Flag Coverage Δ
#multiple 90.62% <ø> (ø) ⬆️
#single 42.3% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bce1a...f6d291e. Read the comment docs.

@WillAyd

This comment has been minimized.

Copy link
Member

commented Nov 18, 2018

Is this running the same number of tests as before? Might have missed it in another change but not immediately apparent how these are getting run for each of the subclasses.

Totally +1 on the change just want to double check we get the proper execution

@jreback jreback merged commit bb96447 into pandas-dev:master Nov 18, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20181118.14 succeeded
Details
@jreback

This comment has been minimized.

Copy link
Contributor

commented Nov 18, 2018

thanks @gfyoung some minor comments can followup with (or create issues if they are non-trivial).

@gfyoung gfyoung deleted the forking-repos:pytest-parsers-idiom branch Nov 18, 2018

@gfyoung

This comment has been minimized.

Copy link
Member Author

commented Nov 18, 2018

Is this running the same number of tests as before? Might have missed it in another change but not immediately apparent how these are getting run for each of the subclasses.

@WillAyd : All of the tests are intact. You are more than welcome to confirm. 🙂

gfyoung added a commit to forking-repos/pandas that referenced this pull request Nov 19, 2018

gfyoung added a commit to forking-repos/pandas that referenced this pull request Nov 19, 2018

jreback added a commit that referenced this pull request Nov 19, 2018

thoo added a commit to thoo/pandas that referenced this pull request Nov 19, 2018

Merge remote-tracking branch 'upstream/master' into io_csv_docstring_…
…fixed

* upstream/master: (46 commits)
  DEPS: bump xlrd min version to 1.0.0 (pandas-dev#23774)
  BUG: Don't warn if default conflicts with dialect (pandas-dev#23775)
  BUG: Fixing memory leaks in read_csv (pandas-dev#23072)
  TST: Extend datetime64 arith tests to array classes, fix several broken cases (pandas-dev#23771)
  STYLE: Specify bare exceptions in pandas/tests (pandas-dev#23370)
  ENH: between_time, at_time accept axis parameter (pandas-dev#21799)
  PERF: Use is_utc check to improve performance of dateutil UTC in DatetimeIndex methods (pandas-dev#23772)
  CLN: io/formats/html.py: refactor (pandas-dev#22726)
  API: Make Categorical.searchsorted returns a scalar when supplied a scalar (pandas-dev#23466)
  TST: Add test case for GH14080 for overflow exception (pandas-dev#23762)
  BUG: Don't extract header names if none specified (pandas-dev#23703)
  BUG: Index.str.partition not nan-safe (pandas-dev#23558) (pandas-dev#23618)
  DEPR: tz_convert in the Timestamp constructor (pandas-dev#23621)
  PERF: Datetime/Timestamp.normalize for timezone naive datetimes (pandas-dev#23634)
  TST: Use new arithmetic fixtures, parametrize many more tests (pandas-dev#23757)
  REF/TST: Add more pytest idiom to parsers tests (pandas-dev#23761)
  DOC: Add ignore-deprecate argument to validate_docstrings.py (pandas-dev#23650)
  ENH: update pandas-gbq to 0.8.0, adds credentials arg (pandas-dev#23662)
  DOC: Improve error message to show correct order (pandas-dev#23652)
  ENH: Improve error message for empty object array (pandas-dev#23718)
  ...

brute4s99 added a commit to brute4s99/pandas that referenced this pull request Nov 19, 2018

REF/TST: Add more pytest idiom to parsers tests (pandas-dev#23761)
Adds more idiom to the following:

* parser/comment --> parser/test_comment
* parser/converters --> parser/test_converters
* parser/compression --> parser/test_compression
* parser/dialect --> parser/test_dialect

Builds off of pandas-devgh-23712.

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

REF/TST: Add more pytest idiom to parsers tests (pandas-dev#23761)
Adds more idiom to the following:

* parser/comment --> parser/test_comment
* parser/converters --> parser/test_converters
* parser/compression --> parser/test_compression
* parser/dialect --> parser/test_dialect

Builds off of pandas-devgh-23712.

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

REF/TST: Add more pytest idiom to parsers tests (pandas-dev#23761)
Adds more idiom to the following:

* parser/comment --> parser/test_comment
* parser/converters --> parser/test_converters
* parser/compression --> parser/test_compression
* parser/dialect --> parser/test_dialect

Builds off of pandas-devgh-23712.

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.