Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS: bump xlrd min version to 1.0.0 #23774

Merged
merged 5 commits into from Nov 19, 2018

Conversation

Projects
None yet
3 participants
@jreback
Copy link
Contributor

commented Nov 19, 2018

remove numpy warnings on np.diff in boolean arrays

@jreback jreback added this to the 0.24.0 milestone Nov 19, 2018

@jreback jreback force-pushed the jreback:bump branch from c5703d0 to 34f1f0a Nov 19, 2018

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Nov 19, 2018

removes all of those annoying warnings on 2.7 build :>

@codecov

This comment has been minimized.

Copy link

commented Nov 19, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@2946745). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #23774   +/-   ##
=========================================
  Coverage          ?   92.28%           
=========================================
  Files             ?      161           
  Lines             ?    51451           
  Branches          ?        0           
=========================================
  Hits              ?    47483           
  Misses            ?     3968           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.68% <100%> (?)
#single 42.28% <33.33%> (?)
Impacted Files Coverage Δ
pandas/core/indexes/period.py 93.07% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2946745...b1cf09f. Read the comment docs.

@pep8speaks

This comment has been minimized.

Copy link

commented Nov 19, 2018

Hello @jreback! Thanks for updating the PR.

@@ -652,7 +653,8 @@ def get_value(self, series, key):
except TypeError:
pass

key = Period(key, self.freq).ordinal
period = Period(key, self.freq)
key = period.value if isna(period) else period.ordinal

This comment has been minimized.

Copy link
@jreback

jreback Nov 19, 2018

Author Contributor

cc @jbrockmendel I had to make this change here. Not sure how this actually worked before.

@jreback jreback force-pushed the jreback:bump branch from 64d0097 to c499603 Nov 19, 2018

@jreback jreback force-pushed the jreback:bump branch from c499603 to b1cf09f Nov 19, 2018

@jreback

This comment has been minimized.

Copy link
Contributor Author

commented Nov 19, 2018

@TomAugspurger if any comments

@TomAugspurger
Copy link
Contributor

left a comment

Not sure about the period change (the change itself looks fine / necessary. Not sure why it wasn't needed / working before).

@jreback jreback merged commit deb7b4d into pandas-dev:master Nov 19, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pandas-dev.pandas Build #20181119.37 succeeded
Details

thoo added a commit to thoo/pandas that referenced this pull request Nov 19, 2018

Merge remote-tracking branch 'upstream/master' into io_csv_docstring_…
…fixed

* upstream/master: (46 commits)
  DEPS: bump xlrd min version to 1.0.0 (pandas-dev#23774)
  BUG: Don't warn if default conflicts with dialect (pandas-dev#23775)
  BUG: Fixing memory leaks in read_csv (pandas-dev#23072)
  TST: Extend datetime64 arith tests to array classes, fix several broken cases (pandas-dev#23771)
  STYLE: Specify bare exceptions in pandas/tests (pandas-dev#23370)
  ENH: between_time, at_time accept axis parameter (pandas-dev#21799)
  PERF: Use is_utc check to improve performance of dateutil UTC in DatetimeIndex methods (pandas-dev#23772)
  CLN: io/formats/html.py: refactor (pandas-dev#22726)
  API: Make Categorical.searchsorted returns a scalar when supplied a scalar (pandas-dev#23466)
  TST: Add test case for GH14080 for overflow exception (pandas-dev#23762)
  BUG: Don't extract header names if none specified (pandas-dev#23703)
  BUG: Index.str.partition not nan-safe (pandas-dev#23558) (pandas-dev#23618)
  DEPR: tz_convert in the Timestamp constructor (pandas-dev#23621)
  PERF: Datetime/Timestamp.normalize for timezone naive datetimes (pandas-dev#23634)
  TST: Use new arithmetic fixtures, parametrize many more tests (pandas-dev#23757)
  REF/TST: Add more pytest idiom to parsers tests (pandas-dev#23761)
  DOC: Add ignore-deprecate argument to validate_docstrings.py (pandas-dev#23650)
  ENH: update pandas-gbq to 0.8.0, adds credentials arg (pandas-dev#23662)
  DOC: Improve error message to show correct order (pandas-dev#23652)
  ENH: Improve error message for empty object array (pandas-dev#23718)
  ...

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.